8000 Fix crash when diffing a stack that has unquoted date strings by aarongorka · Pull Request #768 · cloudtools/stacker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix crash when diffing a stack that has unquoted date strings #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix crash when diffing a stack that has unquoted date strings #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a05838f
Fix crash when diffing a stack that has unquoted date strings
aarongorka Feb 3, 2021
149b24b
Update CHANGELOG.md with date string crash fix
aarongorka Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## Upcoming release
- Fix crash on `stacker diff` when comparing a template with unquoted date strings

## 1.7.2 (2020-11-09)
- address breaking moto change to awslambda [GH-763]
Expand Down
2 changes: 1 addition & 1 deletion stacker/providers/aws/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ def get_stack_info(self, stack):
if isinstance(template, str): # handle yaml templates
template = parse_cloudformation_template(template)

return [json.dumps(template), parameters]
return [json.dumps(template, default=str), parameters]

def get_stack_changes(self, stack, template, parameters,
tags, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion stacker/tests/fixtures/cfn_template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
AWSTemplateFormatVersion: "2010-09-09"
AWSTemplateFormatVersion: 2010-09-09
Description: TestTemplate
Parameters:
Param1:
Expand Down
0