Removed validation for DBSubnetGroupName when creating a read replica #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with SourceDBInstanceIdentifier
|
Thanks! |
amosshapira
pushed a commit
to amosshapira/troposphere
that referenced
this pull request
Oct 24, 2016
… with SourceDBInstanceIdentifier (cloudtools#515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a read replica using CloudFormation, the read replica will always be created in the default VPC unless the DBSubnetGroupName is stated.
Prior to this PR, DBSubnetGroupName is not allowed to be stated when SourceDBInstanceIdentifier is stated.
AWS documentation also does not state the DBSubnetGroupName cannot be stated when SourceDBInstanceIdentifier is.
A point to note when creating replica is when a read replica is already created in the region, the next read replica will always be created in the same VPC as the first read replica. This has been verified by AWS Support and also this StackOverflow post.