-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Removed the DBSubnetGroupName limitation on rds replica #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the cloudformation attribute setting into __setattr__ so the attributes (like Metadata) can be set after object initialization.
…az_test only validate elasticache az choices if azs is a list
adds from_dict function to BaseAWSObject allowing for objects to be created from data structures
…roles-and-instance-profiles Path is optional for Role and InstanceProfile
Validate parameter options based on Type
…alidation Add more specific validators to DBInstance
Add constants for the parameter types
Add lambda ZipFile property
Adds VPCEndpoint resource type
Supports tags in ElasticBeanstalk environments
Move cloudformation attribute setting to __setattr__
Fix Ref/GetAtt issue w/ DBInstance
This lets you figure out what resource you were working on when the issue popped up.
This lets external libraries use this function.
`get_events` will return all events that have occurred for a stack. This is useless if we're tailing an update to a stack.
…essages Gives more info about type errors
Refactor tail
This new Template subclass makes it possible to import most Cloudformation templates as JSON and parse them as Troposphere objects. This is different from cfn2py in that it's not trying to write actual python code, but rather instantiate the actual objects without the need to edit it afterwards. There are probably a few tropo-specific AWSHelperFns that won't be parsed correctly, but the ones included in the tests/examples_output are all supported. I believe an effort should be done to normalize the helper functions into something discoverable with a consistent use - but I have yet to really ponder on that issue.
Add requirements doc for python. Versions tested with python 2.7.
The documentation is unclear but the example (and my testing) shows that this is the correct syntax https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-config-configrule.html#cfn-config-configrule-source
* Update to Apr 25, 2016 release
* EMR: change EBS configuration (moved from Cluster to InstanceGroupConfigProperty) * Fix EMR_Cluster example (cloudformation stack now succeeds, but EMR step fails because of obviously unexisting S3 bucket in my account)
The documentation lies, here's the error message I just got from CloudFormation: "CloudFormation currently only supports long-running clusters, set ActionOnFailure to CANCEL_AND_WAIT or CONTINUE"
* Allow setting a different region for S3 upload * Maintain backwards compatibility by setting s3region to region if not specified * Fix help statement default for s3 region to be us-east-1 instead of None
* Add ability to update instead of always running create
Thanks. Dup of #515 which has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBSubnetGroupName is not a limitation of a RDS replica.
Previous Troposphere version had a limitation for when SourceDBInstanceIdentifier parameter was defined in a DBInstance.
AWS documentation has no reference of this limitation and it's the only way to create an rds replica on a custom VPC instead of in the default one.