8000 Align AnimationEventType with EventType updates in Spine C++. by bofeng-song · Pull Request #18719 · cocos/cocos-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Align AnimationEventType with EventType updates in Spine C++. #18719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails 8000 .

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Align AnimationEventType with EventType updates in Spine C++. #18719

merged 1 commit into from
May 19, 2025

Conversation

bofeng-song
Copy link
Contributor
@bofeng-song bofeng-song commented May 16, 2025 •
edited
Loading

Re: #
#18671

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from star-e May 16, 2025 02:28
@star-e
Copy link
Contributor
star-e commented May 16, 2025

@cocos-robot run test cases

@github-actions GitHub Actions
Copy link

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1005977 bytes 1005977 bytes ✅ 0 bytes
2D All (legacy pipeline) 2669829 bytes 2669829 bytes ✅ 0 bytes
2D All (new pipeline) 2758336 bytes 2758336 bytes ✅ 0 bytes
(2D + 3D) All 10014285 bytes 10014285 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16831460 bytes 16831460 bytes ✅ 0 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -53288,19 +53288,19 @@
              * @property {Number} END
              */
             END = 2,
             /**
-             * @en The entry will be disposed.
-             * @zh entry 将被销毁。
-             */
-            DISPOSE = 3,
-            /**
              * @en The play spine skeleton animation complete type.
              * @zh 播放骨骼动画完成。
              * @property {Number} COMPLETE
              */
-            COMPLETE = 4,
+            COMPLETE = 3,
             /**
+             * @en The entry will be disposed.
+             * @zh entry 将被销毁。
+             */
+            DISPOSE = 4,
+            /**
              * @en The spine skeleton animation event type.
              * @zh 骨骼动画事件。
              * @property {Number} EVENT
              */

@github-actions GitHub Actions
Copy link

@bofeng-song, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL graphics-continuous-filling
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions GitHub Actions
Copy link

@bofeng-song, Please check the result of run test cases:

Task Details

@star-e star-e merged commit 84fae75 into cocos:v3.8.7 May 19, 2025
15 checks passed
@bofeng-song bofeng-song deleted the 387_spine_event branch May 19, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@star-e star-e Awaiting requested review from star-e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bofeng-song @star-e
0