cloud/amazon: retry errors during s3 bucket region lookup #79974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
might be worth backporting this to 22.1, 21.x ? |
Currently errors encountered during s3 bucket region lookup is swallowed. If there is an error during this step then a client is created with an empty region, which will then issue invalid requests with an empty region. This patch fixes the bug. Fixes cockroachdb#79435 Release note: None
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errors encountered during s3 bucket region lookup is swallowed. If
there is an error during this step then a client is created with an empty
region, which will then issue invalid requests with an empty region. This
patch fixes the bug.
Fixes #79435
Release note: None