8000 release-21.2: release-22.1: cloud/amazon: retry errors during s3 bucket region lookup by adityamaru · Pull Request #83424 · cockroachdb/cockroach · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

release-21.2: release-22.1: cloud/amazon: retry errors during s3 bucket region lookup #83424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2022
Merged

release-21.2: release-22.1: cloud/amazon: retry errors during s3 bucket region lookup #83424

merged 1 commit into from
Jun 27, 2022

Conversation

adityamaru
Copy link
Contributor

Backport 1/1 commits from #80242.

/cc @cockroachdb/release

Backport 1/1 commits from #79974 on behalf of @rhu713.

/cc @cockroachdb/release

Currently errors encountered during s3 bucket region lookup is swallowed. If
there is an error during this step then a client is created with an empty
region, which will then issue invalid requests with an empty region. This
patch fixes the bug.

Fixes #79435

Release note: None

Release justification: Fix bug for s3 storage not exposing region lookup errors.

@adityamaru adityamaru requested review from rhu713 and a team June 27, 2022 16:26
@adityamaru adityamaru requested a review from a team as a code owner June 27, 2022 16:26
@adityamaru adityamaru requested review from HonoreDB and removed request for a team June 27, 2022 16:26
@blathers-crl
Copy link
blathers-crl bot commented Jun 27, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
cloud/amazon: retry errors during s3 bucket region lookup
6fd632e 
Currently errors encountered during s3 bucket region lookup is swallowed. If
there is an error during this step then a client is created with an empty
region, which will then issue invalid requests with an empty region. This
patch fixes the bug.

Fixes cockroachdb#79435

Release note: None
@adityamaru adityamaru force-pushed the backport21.2-80242 branch from 4be9d8e to 6fd632e Compare June 27, 2022 17:23
@adityamaru
Copy link
Contributor Author

I ran the s3 tests locally to ensure we are not introducing a regression.

@adityamaru adityamaru merged commit a3c796b into cockroachdb:release-21.2 Jun 27, 2022
@adityamaru adityamaru deleted the backport21.2-80242 branch June 27, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhu713 rhu713 rhu713 approved these changes

@HonoreDB HonoreDB Awaiting requested review from HonoreDB HonoreDB is a code owner automatically assigned from cockroachdb/cdc-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityamaru @cockroach-teamcity @rhu713
0