ui: add connected component for jobs pages #83901
Conversation
|
This change is |
|
On the CC Console (with local On the DB Console: |
54e50a9 to
60cc28b
Compare
60cc28b to
74f1441
Compare
There was a problem hiding this comment.
Awesome job on the Jobs! 😄
Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)
pkg/ui/workspaces/cluster-ui/src/store/utils/selectors.ts line 22 at r1 (raw file):
adminUISelector, adminUiState => adminUiState.localStorage, );
Really nice refactor!!
This commit adds "connected" components for the jobs pages. These components can be imported from the cluster-ui package into the managed service repo and used on the CC console. Release note: None
74f1441 to
046d6e6
Compare
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/ui/w
8000
orkspaces/cluster-ui/src/store/utils/selectors.ts line 22 at r1 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
Really nice refactor!!
😊
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
This PR adds "connected" components for the jobs pages. These components can be imported from the
cluster-uipackage into themanaged-servicerepo and used on the CC console for Dedicated clusters (serverless clusters do not support the admin server that handles job requests).Related to #71324.
Release note: None