8000 ui: fix copy in DB console jobs table by ericharmeling · Pull Request #83914 · cockroachdb/cockroach · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ui: fix copy in DB console jobs table #83914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericharmeling
Copy link
@ericharmeling ericharmeling commented Jul 6, 2022

This commit makes a minor change to the Jobs table in the DB
console.

These changes are also present in #83901.

Fixes #83872.

Release note (ui change): Updated User column name to User Name and fixed High-water Timestamp column tooltip on the Jobs page.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ericharmeling ericharmeling requested a review from a team July 6, 2022 17:28
Copy link
Contributor
@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)

Copy link
Contributor
@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)


-- commits line 9 at r1:
add a ui change as release note, so the docs team know they need to update column name and screenshots

@ericharmeling ericharmeling force-pushed the jobs-table-copy-fixes branch from 1e25822 to 2a19a51 Compare July 7, 2022 18:48
Copy link
Author
@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @maryliag)


-- commits line 9 at r1:

Previously, maryliag (Marylia Gutierrez) wrote…

add a ui change as release note, so the docs team know they need to update column name and screenshots

Done!

@ericharmeling ericharmeling requested a review from maryliag July 7, 2022 18:48
maryliag
< 8000 a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/maryliag/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/maryliag">maryliag approved these changes Jul 7, 2022
Copy link
Contributor
@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @ericharmeling)

This commit makes a minor change to the Jobs table in the DB
console.

Fixes cockroachdb#83872.

Release note (ui change): Updated `User` column name to `User Name`
and fixed `High-water Timestamp` column tooltip on the Jobs page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0