8000 codelanguages should different base on coco/oz by smallst · Pull Request #7689 · codecombat/codecombat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

codelanguages should different base on coco/oz #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2024
Merged

codelanguages should different base on coco/oz #7689

merged 2 commits into from
Sep 11, 2024

Conversation

smallst
Copy link
Contributor
@smallst smallst commented Sep 10, 2024 •
edited by coderabbitai bot
Loading

image
fix ENG-1145

Summary by CodeRabbit

  • Refactor

    • Improved code readability and consistency through formatting adjustments, including indentation and line breaks.
    • Restructured the getCodeLanguages function for better organization and clarity in logic flow.

  • Chores

    • Minor updates to the formatting of several functions to align with standard practices, enhancing overall maintainability.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Sep 10, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces various formatting and structural changes to the app/core/utils.js file. These modifications enhance code readability and maintain consistency in indentation and line breaks across multiple functions. Additionally, the getCodeLanguages function has been restructured to improve the organization of the code, particularly regarding the conditional inclusion of languages based on the isCodeCombat flag.

Changes

Files Change Summary
app/core/utils.js Reformatted functions for improved readability; restructured getCodeLanguages for better organization.

Assessment against linked issues

Objective Addressed Explanation
remove cpp, java from oz create classroom (ENG-1145) ❌ The PR does not include any removal of cpp and java.

🐰 In the code, a change we see,
Formatting bright as a sunny spree!
Functions align, logic flows clear,
A rabbit hops in with joyful cheer!
Code's now tidy, a sight so grand,
Let's celebrate with a happy hand! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

adamkecskes
adamkecskes reviewed Sep 10, 2024
View reviewed changes
app/core/utils.js Outdated
}
})
if (isCodeCombat) {
return Object.assign({}, codeLanguages, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but why is the first the empty object as the first argument? return { ...codeLanguages, coffeescript:..., lua:... } would be cleaner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes. first empty object to prevent Object.assign change codeLanguage object

adamkecskes
adamkecskes approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator
@adamkecskes adamkecskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smallst smallst merged commit 8a6fe77 into master Sep 11, 2024
1 of 2 checks passed
@smallst smallst deleted the yuqiang/oz-classroom-languages-fix branch September 11, 2024 01:49
@coderabbitai coderabbitai bot mentioned this pull request Nov 25, 2024
Closed
@coderabbitai coderabbitai bot mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrfinch mrfinch mrfinch approved these changes

@adamkecskes adamkecskes adamkecskes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smallst @mrfinch @adamkecskes
0