8000 fix: Update the PR comment footer copy by RulaKhaled · Pull Request #854 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: Update the PR comment footer copy #854

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix: Update the PR comment footer copy #854

merged 4 commits into from
Nov 6, 2024

Conversation

RulaKhaled
Copy link
Contributor

Updating the PR comment as described in #2711

Screenshot 2024-11-06 at 10 57 07 AM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link
codecov-notifications bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         444      445       +1     
  Lines       36057    36099      +42     
==========================================
+ Hits        35346    35384      +38     
- Misses        711      715       +4     
Flag Coverage Δ
integration 98.01% <100.00%> (-0.01%) ⬇️
unit 98.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.05% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/test_results.py 90.00% <100.00%> (ø)
services/tests/test_test_results.py 100.00% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <ø> (ø)

... and 20 files with indirect coverage changes

Copy link
codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (1e2c27a) to head (ee4315b).
Report is 1 commits behind head on main.

Current head ee4315b differs from pull request most recent head fca9a4c

Please upload reports for the commit fca9a4c to get more accurate results.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         444      444           
  Lines       36057    36057           
=======================================
  Hits        35346    35346           
  Misses        711      711           
Flag Coverage Δ
integration 98.02% <100.00%> (ø)
unit 98.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <100.00%> (ø)
OutsideTasks 98.05% <100.00%> (ø)
Files with missing lines Coverage Δ
services/test_results.py 90.00% <100.00%> (ø)
services/tests/test_test_results.py 100.00% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <ø> (ø)

@codecov-qa
Copy link
codecov-qa bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (1e2c27a) to head (fca9a4c).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         444      445       +1     
  Lines       36057    36099      +42     
==========================================
+ Hits        35346    35384      +38     
- Misses        711      715       +4     
Flag Coverage Δ
integration 98.01% <100.00%> (-0.01%) ⬇️
unit 98.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.05% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/test_results.py 90.00% <100.00%> (ø)
services/tests/test_test_results.py 100.00% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <ø> (ø)

... and 20 files with indirect coverage changes

Copy link
codecov-public-qa bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (1e2c27a) to head (fca9a4c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         444      445       +1     
  Lines       36057    36099      +42     
==========================================
+ Hits        35346    35384      +38     
- Misses        711      715       +4     
Flag Coverage Δ
integration 98.01% <100.00%> (-0.01%) ⬇️
unit 98.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.05% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
services/test_results.py 90.00% <100.00%> (ø)
services/tests/test_test_results.py 100.00% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <ø> (ø)

... and 20 files with indirect coverage changes

@@ -198,7 +198,7 @@ def generate_failure_info(
def generate_view_test_analytics_line(commit: Commit) -> str:
repo = commit.repository
test_analytics_url = get_test_analytics_url(repo, commit)
return f"\nTo view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard]({test_analytics_url})"
return f"\nTo view more test analytics go to the [Test Analytics Dashboard]({test_analytics_url})\nGot feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there should be a comma after analytics
To view more test analytics, go to the...

@RulaKhaled RulaKhaled enabled auto-merge November 6, 2024 15:10
@RulaKhaled RulaKhaled added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit f6f66e8 Nov 6, 2024
21 of 23 checks passed
@RulaKhaled RulaKhaled deleted the fix-footer-copy branch November 6, 2024 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0