-
Notifications
You must be signed in to change notification settings - Fork 11
fix: Update the PR comment footer copy #854
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 98.02% 98.01% -0.01%
==========================================
Files 444 445 +1
Lines 36057 36099 +42
==========================================
+ Hits 35346 35384 +38
- Misses 711 715 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 444 444
Lines 36057 36057
=======================================
Hits 35346 35346
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 98.02% 98.01% -0.01%
==========================================
Files 444 445 +1
Lines 36057 36099 +42
==========================================
+ Hits 35346 35384 +38
- Misses 711 715 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 98.02% 98.01% -0.01%
==========================================
Files 444 445 +1
Lines 36057 36099 +42
==========================================
+ Hits 35346 35384 +38
- Misses 711 715 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/test_results.py
Outdated
@@ -198,7 +198,7 @@ def generate_failure_info( | |||
def generate_view_test_analytics_line(commit: Commit) -> str: | |||
repo = commit.repository | |||
test_analytics_url = get_test_analytics_url(repo, commit) | |||
return f"\nTo view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard]({test_analytics_url})" | |||
return f"\nTo view more test analytics go to the [Test Analytics Dashboard]({test_analytics_url})\nGot feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there should be a comma after analytics
To view more test analytics, go to the...
Updating the PR comment as described in #2711
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.