8000 fix: Update the PR comment footer copy by RulaKhaled · Pull Request #854 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: Update the PR comment footer copy #854

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix: Update the PR comment footer copy #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33c25c5
fix: Update the PR comment footer copy
RulaKhaled Nov 6, 2024
ffc6ae4
Add tests
RulaKhaled Nov 6, 2024
ee4315b
More tests fixing
RulaKhaled Nov 6, 2024
fca9a4c
Adding comma
RulaKhaled Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/test_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def generate_failure_info(
def generate_view_test_analytics_line(commit: Commit) -> str:
repo = commit.repository
test_analytics_url = get_test_analytics_url(repo, commit)
return f"\nTo view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard]({test_analytics_url})"
return f"\nTo view more test analytics, go to the [Test Analytics Dashboard]({test_analytics_url})\nGot feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)"


def messagify_failure(
Expand Down
6 changes: 4 additions & 2 deletions services/tests/test_test_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ def test_build_message():

</details>

To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/thing%2Fthing)"""
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/thing%2Fthing)
Got feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)"""
)


Expand Down Expand Up @@ -186,7 +187,8 @@ def test_build_message_with_flake():

</details>

To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/{commit.branch})"""
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/{commit.branch})
Got feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)"""
)


Expand Down
12 changes: 8 additions & 4 deletions tasks/tests/unit/test_test_results_finisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@ def test_upload_finisher_task_call(

</details>

To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
Got feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)""",
)

@pytest.mark.integration
Expand Down Expand Up @@ -719,7 +720,8 @@ def test_upload_finisher_task_call_existing_comment(

</details>

To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
Got feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)""",
)

assert expected_result == result
Expand Down Expand Up @@ -865,7 +867,8 @@ def test_upload_finisher_task_call_with_flaky(

</details>

To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
Got feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)""",
)

@pytest.mark.integration
Expand Down Expand Up @@ -1049,5 +1052,6 @@ def test_upload_finisher_task_call_computed_name(

</details>

To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
Got feedback? Let us know on [Github](https://github.com/codecov/feedback/issues)""",
)
Loading
0