10000 Upgrade to pybind11 v2.12. Fix bind_map and reconstruction.points3D by B1ueber2y · Pull Request #2502 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to pybind11 v2.12. Fix bind_map and reconstruction.points3D #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2024
Merged

Upgrade to pybind11 v2.12. Fix bind_map and reconstruction.points3D #2502

merged 6 commits into from
Apr 13, 2024

Conversation

B1ueber2y
Copy link
Contributor

This pull request contains the following updates:

  1. upgrade pybind11 to v2.12, where the bug for py::bind_map has been fixed. Remove the py::bind_map_fix implemented from @sarlinpe.
  2. Fix the reconstruction.points3D performance issue incurred by the build time reduction commit
  3. Minor addition of bindings for reconstruction class

@sarlinpe
Copy link
Member
sarlinpe commented Apr 9, 2024

You also need to update this

colmap/pycolmap/pyproject.toml

Line 2 in 0ea2d5c

requires = ["scikit-build-core>=0.3.3", "pybind11==2.11.1"]

@B1ueber2y
Copy link
Contributor Author

You also need to update this

colmap/pycolmap/pyproject.toml

Line 2 in 0ea2d5c

requires = ["scikit-build-core>=0.3.3", "pybind11==2.11.1"]

Done

@sarlinpe sarlinpe enabled auto-merge (squash) April 13, 2024 21:17
@sarlinpe sarlinpe merged commit 79c79f4 into colmap:main Apr 13, 2024
@versatran01 versatran01 mentioned this pull request Apr 17, 2024
Closed
@B1ueber2y B1ueber2y deleted the fix/reconstruction_points3D branch April 18, 2024 06:35
This was referenced Apr 18, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
M 3E92 ilestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B1ueber2y @sarlinpe
0