8000 Fix reconstruction.points3D by B1ueber2y · Pull Request #2523 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix reconstruction.points3D #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix reconstruction.points3D #2523

merged 2 commits into from
Apr 18, 2024

Conversation

B1ueber2y
Copy link
Contributor
@B1ueber2y B1ueber2y commented Apr 18, 2024 •
edited
Loading

Need to add PYBIND11_MAKE_OPAQUE(Point3DMap) in both "reconstruction" and "point3D" to make the conversion correct. Fix for #2502

cc: @sarlinpe for #2522

@B1ueber2y B1ueber2y mentioned this pull request Apr 18, 2024
Closed
@sarlinpe sarlinpe merged commit cfbc805 into colmap:main Apr 18, 2024
@B1ueber2y B1ueber2y deleted the fix/reconstruction_bindings branch April 18, 2024 13:41
@B1ueber2y B1ueber2y mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B1ueber2y @sarlinpe
0