Add aligned allocator for ListPoint2D #95
Conversation
|
@Phil26AT It seems that colmap has added a macro to deal with the alignment: https://github.com/colmap/colmap/blob/master/src/base/point2d.h#L96 |
|
@guohengkai I am a bit clueless then, for me this fixes the issue. Are you using ceres v2.2? Then maybe try to compile colmap explicitly with -std=c++17 (this is still missing in the colmap cmake, atm it will still use c++14, but ceres uses c++17). You can switch to C++17 here: https://github.com/colmap/colmap/blob/e180948665b03c4a12d45e2ca39a589f42fdbda6/src/CMakeLists.txt#L46 Can you maybe open an issue with your ceres and colmap commit hash? |
|
@Phil26AT Sure. I will construct a minimal code snipper to reproduce it and submit an issue later. Thanks. |
|
Hey @guohengkai @Phil26AT, any progress on this? Thanks! |
Problem: COLMAP uses Eigens aligned allocator for vectors of Point2D.
This PR ensures that
pycolmap.ListPoint2Dalso uses this aligned allocator (previously causedMaxRecursionErrorin some cases).