Don't use Zinc analysis file to find main classes #4819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be requested explicitly, since the default package can't be "found" by design, as it has no name and can't be imported. Added tests.
lihaoyi
reviewed
Mar 30, 2025
| val mainClasses = for { | ||
| foundPackage <- recursive("", (p: String) => path.packages(p).map(_.name)) | ||
| foundPackage <- defaultPackage +: recursive("", (p: String) => path.packages(p).map(_.name)) |
There was a problem hiding this comment.
This whole def recursive thing that was copy-pasted from elsewhere can probably be replaced by the following snippet from the other PR
def recursivePackages(p: String) = Seq(p) ++ path.packages(p).map(_.name)
val mainClasses = for {
foundPackage <- recursivePackages("")There was a problem hiding this comment.
Got it. I just wanted to see all test green before I change that "working" part of the code.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.