Find main classes with ClassGraph #4822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the scalap approach doesn't work for jlink/jpackage modules and scalap seems discontinued in Scala 3 anyways, this is an attempt to use ClassGraph (https://github.com/classgraph/classgraph) to find main classes. Added tests for allLocalMainClasses (in the default package).
lihaoyi
approved these changes
Mar 31, 2025
lihaoyi
reviewed
Mar 31, 2025
lihaoyi
reviewed
Mar 31, 2025
<
8000
a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-commit-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/lefou/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/lefou">lefou
added 2 commits
March 31, 2025 15:17
lihaoyi
approved these changes
Mar 31, 2025
|
@lihaoyi Do we want this backported to 0.12? |
|
@lefou sure let's do that, it's not a breaking change and doesn't rely on any of the other new stuff |
lefou
added a commit
to lefou/mill
that referenced
this pull request
Mar 31, 2025
Since the scalap approach doesn't work for jlink/jpackage modules and scalap seems discontinued in Scala 3 anyways, this is an attempt to use ClassGraph (https://github.com/classgraph/classgraph) to find main classes. Added tests for allLocalMainClasses (in the default package). Removed all alternative implementations to find main classes. Original pull request: com-lihaoyi#4822
lefou
added a commit
to lefou/mill
that referenced
this pull request
Apr 1, 2025
Since the scalap approach doesn't work for jlink/jpackage modules and scalap seems discontinued in Scala 3 anyways, this is an attempt to use ClassGraph (https://github.com/classgraph/classgraph) to find main classes. Added tests for allLocalMainClasses (in the default package). Removed all alternative implementations to find main classes. Original pull request: com-lihaoyi#4822
lefou
added a commit
that referenced
this pull request
Apr 1, 2025
Since the scalap approach doesn't work for jlink/jpackage modules and scalap seems discontinued in Scala 3 anyways, this is an attempt to use ClassGraph (https://github.com/classgraph/classgraph) to find main classes. Added tests for allLocalMainClasses (in the default package). Removed all alternative implementations to find main classes. Original pull request: #4822 Pull request: #4832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the scalap approach doesn't work for jlink/jpackage modules and scalap seems discontinued in Scala 3 anyways,
this is an attempt to use ClassGraph (https://github.com/classgraph/classgraph) to find main classes.
Added tests for allLocalMainClasses (in the default package).
Removed all alternative implementations to find main classes.