8000 Brand Port: GWM Haval h6 2024 by AlexandreSato · Pull Request #1086 · commaai/opendbc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Brand Port: GWM Haval h6 2024 #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

Brand Port: GWM Haval h6 2024 #1086

wants to merge 35 commits into from

Conversation

AlexandreSato
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Aug 18, 2024 •
edited
Loading

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@AlexandreSato AlexandreSato mentioned this pull request Aug 18, 2024
Closed
23 tasks
@AlexandreSato AlexandreSato changed the title Port gwm haval h6 Brand Port: GWM Haval h6 2024 Aug 18, 2024
@github-actions github-actions bot added DBC signals car related to opendbc/car/ fingerprint labels Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 18, 2024
@adeebshihadeh
Copy link
Contributor

Can you rebase and clean this up a little? I'm OK merging just this scaffolding to build off of later, but it shouldn't have anything too messy in it.

@adeebshihadeh
Copy link
Contributor
adeebshihadeh commented Jun 1, 2025 •
edited
Loading

@sshane it's impossible to merge this port... we have to fix this mess

image

@sshane
Copy link
Contributor
sshane commented Jun 1, 2025 •
edited
Loading

It's failing for a reason. Is the mess the unclear failures?

@AlexandreSato
Copy link
Contributor Author
AlexandreSato commented Jun 1, 2025 •
edited
Loading

The port is stopped because the owner no longer has the comma3X. We are also not sure if ADAS decisions are made on camera, it may be necessary to intercept elsewhere.

@adeebshihadeh
Copy link
Contributor
adeebshihadeh commented Jun 1, 2025 •
edited
Loading

It's failing for a reason. Is the mess the unclear failures?

I think it's missing the FW query config, but this should just be a nice empty base class.

The port is stopped because the owner no longer has the comma3X. We are also not sure if ADAS decisions are made on camera, it may be necessary to intercept elsewhere.

In that case, I'll close since the DBC we merged should cover this.

@github-actions github-actions bot removed the car related to opendbc/car/ label Jun 1, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Car Ports Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DBC signals stale
Projects
Car Ports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreSato @adeebshihadeh @sshane
0