Subaru: pre-2020 global/Gen1 Impreza / Crosstrek torque limits #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
|
converting to draft include a route or your device' dongle ID if relevant |
|
63c983aefcc56c48/00000001--31309048c1/0 Tighter turns using higher limits. |
cca7156 to
76e057f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream the "correct" values for crosstrek/impreza torque limit. Current limit of 2047 gives good torque on vehicles like 2019 Forester but the earlier launched Impreza/Crosstrek use 3071 so the torque is scaled down unnecessarily.
This is for Global pre-2020 Impreza/Crosstrek as well as the hybrid although that is dashcam only upstream.
The eps/stock limit on these cars for steering is 3071 not 2047.
New Torque is similar but low 8000 er than the 2019 Forester which uses the 2047 limit.
stock Slew rate limit is right around 60. (For the forester it is around 30)
As-is Impreza and Crosstrek cannot keep in the lane in some highway bends and some tighter turns.