8000 Fix torque array assert by adeebshihadeh · Pull Request #2252 · commaai/opendbc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix torque array assert #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Fix torque array assert #2252

merged 1 commit into from
May 16, 2025

Conversation

adeebshihadeh
Copy link
Contributor

Summary

  • verify Honda torque arrays start at zero in CarControllerParams
  • clarify comment explaining this check

Testing

  • ruff check opendbc/car/honda/values.py
  • pre-commit (fails: command not found)

@github-actions github-actions bot added car related to opendbc/car/ honda labels May 16, 2025
@adeebshihadeh adeebshihadeh merged commit 745d7f0 into master May 16, 2025
9 checks passed
@adeebshihadeh adeebshihadeh deleted the codex/find-and-fix-bug-in-codebase branch May 16, 2025 23:46
vanillagorillaa pushed a commit to vanillagorillaa/opendbc that referenced this pull request May 19, 2025
@adeebshihadeh @vanillagorillaa
Honda: fix torque array assert (commaai#2252)
27b9b40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car related to opendbc/car/ codex honda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adeebshihadeh
0