Hyundai: fix recent enable button press regression #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
regen on master vs. regen on this branch |
vanillagorillaa
pushed a commit
to vanillagorillaa/opendbc
that referenced
this pull request
May 19, 2025
* move back to port * much better * fix button type * fix * need to switch so it works on ports that don't use it, and makes more sense * otherwise it'd be * Revert "otherwise it'd be" This reverts commit 99a9504. * make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We went from checking every 50 Hz CLU11 button message to checking at 100 Hz, so we halve the time we sample for user button presses. I guess this wasn't a problem for most cars, but the issue below shows the PCM enabling a little bit out of the new halved sample window which is now fixed again.
Broken in commaai/openpilot#33710
Closes #2156
Matching old reference carstate and interface: https://github.com/commaai/openpilot/blob/6a15aa3f8c58e40e5e47c7ce4c906f5368ec243a/selfdrive/car/hyundai/interface.py