Tesla: move safety out of debug #2285
Conversation
There was a problem hiding this comment.
let's move RAD_TO_DEG, ISO_LATERAL_ACCEL, and anything else like EARTH out of here
There was a problem hiding this comment.
let's put our jerk limit in the constants file too and leave a comment that it's lower than ISO
There was a problem hiding this comment.
why is there a check for limits.inactive_angle_is_zero? should be constant within a safety mode
There was a problem hiding this comment.
standardize on chksum or checksum
There was a problem hiding this comment.
was TESLA_MAX_SPEED_DELTA verified with data?
There was a problem hiding this comment.
why is there a check for limits.inactive_angle_is_zero? should be constant within a safety mode
It was copied from the standard angle check function, the plan was to combine the two functions. But I think we should refactor the current angle function before doing that as it's way too big
There was a problem hiding this comment.
for brake press,
IBST_driverBrakeApplyhas a fault state we should check
Usually, quality flags describe the signal they protect (ESP_wheelSpeedsQF). That's a generic iBooster status that may or may not be relevant to driver brake press.
Edit: Ah, I see IBST_driverBrakeApply=FAULT #2292
There was a problem hiding this comment.
pull out the invalid speed check, nothing in
modes/should touch controls_allowed. these files are just parsers.
There was a problem hiding this comment.
tesla_steer_angle_cmd_checksshould be moved. again this file should essentially be a parser
There was a problem hiding this comment.
moved some constants: #2300
No description provided.