safety: split longitudinal and lateral checks #2297
Draft
+385
−380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adeebshihadeh did you have any specific ideas about this or want me to explore it further? |
adeebshihadeh
approved these changes
May 24, 2025
Comment on lines
+4
to
+6
| #include "opendbc/safety/safety_helpers.h" | ||
| #include "opendbc/safety/safety_lateral.h" | ||
| #include "opendbc/safety/safety_longitudinal.h" |
There was a problem hiding this comment.
no need for the safety_ prefix - the folder is already called safety!
There was a problem hiding this comment.
helpers doesn't fully capture what's in this file. interpolate is a helper, generic_rx_checks implements safety
| steering_disengage_prev = steering_disengage; | ||
| } | ||
|
|
||
| static void stock_ecu_check(bool stock_ecu_detected) { |
There was a problem hiding this comment.
I'd just put these non-helper functions back in safety.h for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything else stays in safety.h
Need to move common functions like interpolate either into safety_declarations.h or a new file (I added safety_helpers.h for now), might as well move everything? If so, then can main.c and safety.h be the same thing?