CORSの設定を修正 #42
Merged
CORSの設定を修正 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CORS header settings and adjusts invitation-related endpoints and repository method names. Key changes include updating GetByID methods to Find for consistency, modifying the guild invitation verification signature and logging, and updating the route handlers accordingly.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/usecase/*.go | Updated method calls from GetByID to Find and adjusted invitation handling |
| api/service/authorization.go | Added an authorization service for channel access checks |
| api/interface/handler/guild_invitation.go | Renamed invitation handler methods and updated response handling |
| api/infrastructure/persistence/*.go | Renamed persistence methods and corrected repository interface names |
| api/domain/repository/*.go | Updated repository interface method names |
| api/cmd/app/app.go | Modified CORS header values and updated invitation endpoint routes |
| api/test/guild_invitation_test.go | Updated test URL for invitation verification |
Comments suppressed due to low confidence (1)
api/service/authorization.go:24
- In CheckAuthorizationAccessToChannel, if a userChannel is found the user should likely be considered authorized (i.e. return true). Please review whether the logic should be inverted to correctly reflect access control.
if userChannel != nil { return false, nil }
keito0tada
added a commit
that referenced
this pull request
May 22, 2025
* ギルドへの招待を追加 (#36) * modify pr template * ギルドへの招待を追加 * feat(delete_channel) * feat: スキーマ変更 (#39) * feat:スキーマ変更 * chore:スキーマファイルのsyntax errorを修正 * CORSの設定を修正 (#42) * corsの設定を修正 * invitationのtypoを修正 * invitationのレスポンスを修正 * persistenceの関数名の修正 * AuthorizationServiceを追加 * 余計なスラッシュを削除 (#46) --------- Co-authored-by: kasatomorning <9549356+kasatomorning@users.noreply.github.com>
keito0tada
added a commit
that referenced
this pull request
May 22, 2025
* ギルドへの招待を追加 (#36) * modify pr template * ギルドへの招待を追加 * feat(delete_channel) * feat: スキーマ変更 (#39) * feat:スキーマ変更 * chore:スキーマファイルのsyntax errorを修正 * CORSの設定を修正 (#42) * corsの設定を修正 * invitationのtypoを修正 * invitationのレスポンスを修正 * persistenceの関数名の修正 * AuthorizationServiceを追加 * 余計なスラッシュを削除 (#46) * ギルドに参加してもチャンネルに参加できなかった問題を修正 (#48) * チャンネルの権限を確認するサービスを導入 * ログのリファクタ * メッセージの送受信の認可をserviceに変更 --------- Co-authored-by: kasatomorning <9549356+kasatomorning@users.noreply.github.com>
keito0tada
added a commit
that referenced
this pull request
May 24, 2025
* ギルドへの招待を追加 (#36) * modify pr template * ギルドへの招待を追加 * feat(delete_channel) * feat: スキーマ変更 (#39) * feat:スキーマ変更 * chore:スキーマファイルのsyntax errorを修正 * CORSの設定を修正 (#42) * corsの設定を修正 * invitationのtypoを修正 * invitationのレスポンスを修正 * persistenceの関数名の修正 * AuthorizationServiceを追加 * 余計なスラッシュを削除 (#46) * ギルドに参加してもチャンネルに参加できなかった問題を修正 (#48) * チャンネルの権限を確認するサービスを導入 * ログのリファクタ * メッセージの送受信の認可をserviceに変更 * テスト用dbを追加 (#50) * .env.*を無視 * テスト環境を追加 * postgresのversionを固定 * ローカル環境の修正 --------- Co-authored-by: kasatomorning <9549356+kasatomorning@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
CORSの設定などの細かい部分を修正
これでlocalの開発環境も動きそう？
変更点
Issue