feat: スキーマ変更 #39
Merged
feat: スキーマ変更 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the database schema to add timestamp tracking and removes the todos table, and aligns the Go domain models accordingly.
- Remove obsolete
todostable. - Add
created_atandupdated_atcolumns to several tables, and adjust default values. - Extend domain model structs (
User,UserChannels,UserGuilds) withCreatedAtandUpdatedAtfields.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| db/schema.sql | Dropped todos; added timestamp columns; adjusted expiration default |
| api/domain/model/user.go | Imported time; added CreatedAt/UpdatedAt to User |
| api/domain/model/user_channels.go | Imported time; added CreatedAt/UpdatedAt to UserChannels |
| api/domain/model/user_guilds.go | Imported time; added CreatedAt/UpdatedAt to UserGuilds |
Comments suppressed due to low confidence (2)
db/schema.sql:5
- Trailing comma before closing parenthesis can cause SQL syntax errors; remove the comma after the last column definition in the
userstable.
"updated_at" TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
db/schema.sql:62
- The
DEFAULTclause forexpirationis missing a value, resulting in invalid SQL. Specify a default (e.g.,CURRENT_TIMESTAMP) or removeDEFAULT.
"expiration" TIMESTAMP DEFAULT,
Comment on lines
+8
to
+9
| CreatedAt time.Time | ||
| UpdatedAt time.Time |
There was a problem hiding this comment.
[nitpick] Consider adding struct tags (e.g., db:"created_at" json:"created_at") to CreatedAt and UpdatedAt so field names map correctly to your database and JSON.
Suggested change
| CreatedAt time.Time | |
| UpdatedAt time.Time | |
| CreatedAt time.Time `db:"created_at" json:"created_at"` | |
| UpdatedAt time.Time `db:"updated_at" json:"updated_at"` |
Copilot uses AI. Check for mistakes.
Comment on lines
+8
to
+9
| CreatedAt time.Time | ||
| UpdatedAt time.Time |
There was a problem hiding this comment.
[nitpick] Add struct tags for CreatedAt/UpdatedAt to ensure proper mapping between the Go struct and DB column names.
Suggested change
| CreatedAt time.Time | |
| UpdatedAt time.Time | |
| CreatedAt time.Time `db:"created_at"` | |
| UpdatedAt time.Time `db:"updated_at"` |
Copilot uses AI. Check for mistakes.
Comment on lines
+8
to
+9
| CreatedAt time.Time | ||
| UpdatedAt time.Time |
There was a problem hiding this comment.
[nitpick] Include struct tags on the new timestamp fields to keep serialization and database mapping consistent.
Suggested change
| CreatedAt time.Time | |
| UpdatedAt time.Time | |
| CreatedAt time.Time `json:"created_at,omitempty" db:"created_at"` | |
| UpdatedAt time.Time `json:"updated_at,omitempty" db:"updated_at"` |
Copilot uses AI. Check for mistakes.
keito0tada
approved these changes
May 20, 2025
kasatomorning
added a commit
that referenced
this pull request
May 20, 2025
keito0tada
added a commit
that referenced
this pull request
May 22, 2025
* ギルドへの招待を追加 (#36) * modify pr template * ギルドへの招待を追加 * feat(delete_channel) * feat: スキーマ変更 (#39) * feat:スキーマ変更 * chore:スキーマファイルのsyntax errorを修正 * CORSの設定を修正 (#42) * corsの設定を修正 * invitationのtypoを修正 * invitationのレスポンスを修正 * persistenceの関数名の修正 * AuthorizationServiceを追加 * 余計なスラッシュを削除 (#46) --------- Co-authored-by: kasatomorning <9549356+kasatomorning@users.noreply.github.com>
keito0tada
added a commit
that referenced
this pull request
May 22, 2025
* ギルドへの招待を追加 (#36) * modify pr template * ギルドへの招待を追加 * feat(delete_channel) * feat: スキーマ変更 (#39) * feat:スキーマ変更 * chore:スキーマファイルのsyntax errorを修正 * CORSの設定を修正 (#42) * corsの設定を修正 * invitationのtypoを修正 * invitationのレスポンスを修正 * persistenceの関数名の修正 * AuthorizationServiceを追加 * 余計なスラッシュを削除 (#46) * ギルドに参加してもチャンネルに参加できなかった問題を修正 (#48) * チャンネルの権限を確認するサービスを導入 * ログのリファクタ * メッセージの送受信の認可をserviceに変更 --------- Co-authored-by: kasatomorning <9549356+kasatomorning@users.noreply.github.com>
keito0tada
added a commit
that referenced
this pull request
May 24, 2025
* ギルドへの招待を追加 (#36) * modify pr template * ギルドへの招待を追加 * feat(delete_channel) * feat: スキーマ変更 (#39) * feat:スキーマ変更 * chore:スキーマファイルのsyntax errorを修正 * CORSの設定を修正 (#42) * corsの設定を修正 * invitationのtypoを修正 * invitationのレスポンスを修正 * persistenceの関数名の修正 * AuthorizationServiceを追加 * 余計なスラッシュを削除 (#46) * ギルドに参加してもチャンネルに参加できなかった問題を修正 (#48) * チャンネルの権限を確認するサービスを導入 * ログのリファクタ * メッセージの送受信の認可をserviceに変更 * テスト用dbを追加 (#50) * .env.*を無視 * テスト環境を追加 * postgresのversionを固定 * ローカル環境の修正 --------- Co-authored-by: kasatomorning <9549356+kasatomorning@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
スキーマの修正、削除を行った。
変更点
issueにある通り
updated_at/created_atの追加に関しては、domain/modelの変更を行った。
行ったこと
✅
make migrateでの動作確認Issue
Closes: #38