Develop #21
Merged
Develop #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/refactoring db
Feature/logger
チャンネルに入るエンドポイントを実装
There was a problem hiding this comment.
Pull Request Overview
This PR refactors several components of the chat API while removing legacy Todo-related code. Key changes include updates to API specs (OpenAPI), removal of gorm.DB parameter passing in handlers and persistence functions (favoring dependency injection), and the adoption of structured logging (via slog) in place of fmt.Println calls.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/openapi.yaml | Adds the basic OpenAPI spec for the chat API endpoints. |
| api/interface/handler/user.go | Removes DB dependency from constructor; replaces fmt prints with slog logging. |
| api/interface/handler/todo.go | Removes legacy Todo handler functionality. |
| api/interface/handler/message.go | Refactors message handling by removing DB dependency and replacing fmt prints with slog. |
| api/interface/handler/channel.go | Updates channel handler to remove DB dependency and use slog logging. |
| api/infrastructure/persistence/user_channels.go | Refactors user-channel persistence to use injected DB; improves error logging. |
| api/infrastructure/persistence/user.go | Updates user persistence to use injected DB. |
| api/infrastructure/persistence/message.go | Updates message persistence to use injected DB; removes extraneous debug prints. |
| api/infrastructure/persistence/channel.go | Updates channel persistence to use injected DB; removes debug prints. |
| api/cmd/app/app.go | Refactors application setup: injects dependencies, initializes structured logging, etc. |
| Makefile | Adds a test target. |
| .vscode/settings.json | Adds Go-specific editor settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.