8000 Merge `main` into `feature/abci++vef` by sergio-mena · Pull Request #407 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merge main into feature/abci++vef #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 80 commits into from
Mar 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
8b95237
go mod tidy (#104)
thanethomson Jan 13, 2023
d9cae0c
Renaming in docker-related files (#110)
sergio-mena Jan 16, 2023
e79a3eb
build(deps): Bump docker/build-push-action from 3.2.0 to 3.3.0 (#111)
dependabot[bot] Jan 16, 2023
3f2d149
build(deps): Bump bufbuild/buf-setup-action from 1.11.0 to 1.12.0 (#112)
dependabot[bot] Jan 16, 2023
dbaf294
build(deps): Bump google.golang.org/grpc from 1.51.0 to 1.52.0 (#118)
dependabot[bot] Jan 16, 2023
e3509c2
build(deps): Bump github.com/bufbuild/buf from 1.11.0 to 1.12.0 (#117)
dependabot[bot] Jan 16, 2023
88cbf47
replace tm for cmt (#101)
lasarojc Jan 16, 2023
fc48e6f
Fix e2e nightlies in CI, broken by #110 (#138)
sergio-mena Jan 17, 2023
dca9ecf
Rename inside `test/e2e` (#139)
sergio-mena Jan 17, 2023
9975bc8
ci: Fix stalebot config (#131)
thanethomson Jan 17, 2023
6365333
Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebas…
sergio-mena Jan 18, 2023
cf903eb
main: Use unclog for changelog control (#130)
lasarojc Jan 18, 2023
a3221e5
Revert `cometbft-proof` to `tendermint-proof` (#149)
sergio-mena Jan 18, 2023
36d1825
chore: Fix YAML lint errors (#147)
thanethomson Jan 18, 2023
af3bc47
Updated README to reflect renaming (#121)
jmalicevic Jan 18, 2023
fbb9871
Replace tm-db with cometbft-db on `main` (#137)
thanethomson Jan 19, 2023
6c9a7b7
Rename help text on cli commands (#159)
sergio-mena Jan 20, 2023
b8a94dc
ci: Fix Docker builds on `main` (#161)
thanethomson Jan 20, 2023
0b36d31
deps: Bump tm-load-test to v1.3.0 on `main` (#163)
thanethomson Jan 20, 2023
84d76c2
ci: Fix generated code check on `main` (#173)
thanethomson Jan 21, 2023
a36697d
Rename Tendermint to CometBFT in /spec (#143)
cason Jan 23, 2023
38a4cae
main: replace tendermint/tendermint for cometbft/cometbft (#142)
lasarojc Jan 23, 2023
1587e95
tools: remove tm-signer-harness (#177)
jmalicevic Jan 23, 2023
a8e67cc
ci: Remove docs build/deploy workflow (#188)
thanethomson Jan 23, 2023
f617b11
.md - replace references to TM (#148)
jmalicevic Jan 25, 2023
5d54939
Fixes the and removes other networks. (#200)
lasarojc Jan 25, 2023
2f4a09a
main: rename TMHOME to CMTHOME (#212)
lasarojc Jan 27, 2023
c25484f
Renamed prefix in command (#237)
jmalicevic Jan 30, 2023
b27bb3a
Implement uncoordinated upgrades on e2e (#238)
sergio-mena Jan 31, 2023
5954e75
add peer gossip sleep (#241)
sergio-mena Jan 31, 2023
3a0a3fa
ci: Do not suppress output of "make mockery" (#239)
thanethomson Jan 31, 2023
9883814
Rename Tendermint to CometBFT in /docs (#197)
cason Feb 1, 2023
8c32ad8
Update repo root documentation (#252)
thanethomson Feb 1, 2023
1cb55d4
Rename Tendermint to CometBFT: further actions (#224)
cason Feb 1, 2023
12eacdb
build(deps): Bump bufbuild/buf-setup-action from 1.12.0 to 1.13.1 (#235)
dependabot[bot] Feb 1, 2023
1573ad5
build(deps): Bump docker/setup-buildx-action from 2.2.1 to 2.4.0 (#240)
dependabot[bot] Feb 1, 2023
c84a96f
ci: Remove all private repo-related workflow/build config on `main` (…
thanethomson Feb 2, 2023
d159562
Removing all the vuepress related build files and references (#253)
andynog Feb 2, 2023
47d96bc
build(deps): Bump docker/build-push-action from 3.3.0 to 4.0.0 (#267)
dependabot[bot] Feb 6, 2023
dba1452
build(deps): Bump github.com/cosmos/gogoproto from 1.4.3 to 1.4.4 (#271)
dependabot[bot] Feb 6, 2023
16c8c80
build(deps): Bump github.com/spf13/viper from 1.14.0 to 1.15.0 (#276)
dependabot[bot] Feb 6, 2023
0e756e0
build(deps): Bump github.com/vektra/mockery/v2 from 2.16.0 to 2.18.0 …
dependabot[bot] Feb 6, 2023
911742e
build(deps): Bump github.com/bufbuild/buf from 1.12.0 to 1.13.1 (#278)
dependabot[bot] Feb 6, 2023
1cdca34
build(deps): Bump github.com/creachadair/taskgroup from 0.4.2 to 0.5.…
dependabot[bot] Feb 6, 2023
bf71c78
build(deps): Bump github.com/golangci/golangci-lint from 1.50.1 to 1.…
dependabot[bot] Feb 6, 2023
e05009d
build(deps): Bump github.com/gofrs/uuid from 4.3.1+incompatible to 4.…
dependabot[bot] Feb 6, 2023
f1aaa43
build(deps): Bump github.com/go-logfmt/logfmt from 0.5.1 to 0.6.0 (#273)
dependabot[bot] Feb 6, 2023
d82bc77
Updated method for running 200 node test (#285)
sergio-mena Feb 9, 2023
b6571c0
Report Skeleton + Result for homogeneous network (#291)
sergio-mena Feb 9, 2023
f1ce1c5
fix link (#296)
lasarojc Feb 9, 2023
f6e70af
QA: v0.34 - 2/3 TM 1/3 CM (#292)
jmalicevic Feb 10, 2023
6e59854
ci: Update release and pre-release workflows and process (#317)
thanethomson Feb 10, 2023
555ff1d
Fix: typos (#320)
omahs Feb 11, 2023
3dd985b
docs: Update issue and PR templates (#325)
thanethomson Feb 13, 2023
904b413
build(deps): Bump docker/setup-buildx-action from 2.4.0 to 2.4.1 (#331)
dependabot[bot] Feb 13, 2023
af13a8a
build(deps): Bump bufbuild/buf-setup-action from 1.13.1 to 1.14.0 (#332)
dependabot[bot] Feb 13, 2023
ced2df7
build(deps): Bump github.com/vektra/mockery/v2 from 2.18.0 to 2.20.0 …
dependabot[bot] Feb 14, 2023
c436ac4
build(deps): Bump google.golang.org/grpc from 1.52.3 to 1.53.0 (#339)
dependabot[bot] Feb 14, 2023
503f850
build(deps): Bump github.com/bufbuild/buf from 1.13.1 to 1.14.0 (#338)
dependabot[bot] Feb 14, 2023
5922589
build(deps): Bump golang.org/x/crypto from 0.5.0 to 0.6.0 (#335)
dependabot[bot] Feb 14, 2023
2ccf684
QA: v0.34 - 1/3 TM 2/3 CMT (#297)
lasarojc Feb 15, 2023
4a4ddd1
Fix pull request template (#344)
thanethomson Feb 15, 2023
ba097ec
Remove MBT section from contributing guidelines (#343)
thanethomson Feb 15, 2023
36827cb
docs: Update README to reflect test/lint status on release branches (…
thanethomson Feb 15, 2023
6ab7d28
Nenad/150 abci spec fixes (#210)
nenadmilosevic95 Feb 15, 2023
c906604
Use the right code coverage definitions (#352)
lasarojc Feb 17, 2023
8ffeb61
Upgrade to Go 1.19 on `main` (#206)
thanethomson Feb 20, 2023
5a5033f
build(deps): Bump golang.org/x/net from 0.6.0 to 0.7.0 (#358)
dependabot[bot] Feb 20, 2023
82b3862
build(deps): Bump github.com/golangci/golangci-lint from 1.51.1 to 1.…
dependabot[bot] Feb 20, 2023
45a08f3
Allow inclusion of repository in the tag name, so ghcr and dockerub c…
lasarojc Feb 21, 2023
a2d9915
Remove unused code (#286)
hvanz Feb 22, 2023
28baba3
Docs fixes (#368)
andynog Feb 22, 2023
280f4b9
Don't specify the patch version in go-vulncheck (#369)
lasarojc Feb 23, 2023
126f190
ci: Remove Buf tokens from workflow (#378)
thanethomson Feb 23, 2023
d227550
Remove priority mempool (#281)
hvanz Feb 23, 2023
a95a1df
e2e: add manifest fields to enable Prometheus on nodes (#313)
hvanz Feb 24, 2023
d73e622
QA report for 0.37.x alpha3 (#376)
lasarojc Feb 25, 2023
28b130f
Short-term fix for `needProofBlock` problem based on the `main` branc…
adizere Feb 27, 2023
c67d2f7
Re-plot v0.37.x baseline graphs with new script (#395)
sergio-mena Feb 27, 2023
bd9d7e9
Merge branch main into feature/abci++vef
sergio-mena Feb 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .changelog/config.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
project_url = 'https://github.com/cometbft/cometbft'
11 changes: 11 additions & 0 deletions .changelog/epilogue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---

CometBFT is a fork of [Tendermint Core](https://github.com/tendermint/tendermint) as of late December 2022.

## Bug bounty

Friendly reminder, we have a [bug bounty program](https://hackerone.com/cosmos).

## Previous changes

For changes released before the creation of CometBFT, please refer to the Tendermint Core [CHANGELOG.md](https://github.com/tendermint/tendermint/blob/a9feb1c023e172b542c972605311af83b777855b/CHANGELOG.md).
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- The `TMHOME` environment variable was renamed to `CMTHOME`, and all environment variables starting with `TM_` are instead prefixed with `CMT_`
([\#211](https://github.com/cometbft/cometbft/issues/211))
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- [mempool] Remove priority mempool.
([\#260](https://github.com/cometbft/cometbft/issues/260))
- [config] Remove `Version` field from `MempoolConfig`.
([\#260](https://github.com/cometbft/cometbft/issues/260))
- [protobuf] Remove fields `sender`, `priority`, and `mempool_error` from
`ResponseCheckTx`. ([\#260](https://github.com/cometbft/cometbft/issues/260))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[tools/tm-signer-harness]` Set OS home dir to instead of the hardcoded PATH.
([\#6498](https://github.com/tendermint/tendermint/pull/6498))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[state]` Move pruneBlocks from node/state to state/execution.
([\#6541](https://github.com/tendermint/tendermint/pull/6541))
2 changes: 2 additions & 0 deletions .changelog/unreleased/breaking-changes/9468-finalize-block.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[abci]` Introduce `FinalizeBlock` which condenses `BeginBlock`, `DeliverTx` and `EndBlock` into a single method call (@cmwaters)
([\#9468](https://github.com/tendermint/tendermint/pull/9468))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[p2p]` Remove unused p2p/trust package
([\#9625](https://github.com/tendermint/tendermint/pull/9625))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[inspect]` Add a new `inspect` command for introspecting
the state and block store of a crashed tendermint node.
([\#9655](https://github.com/tendermint/tendermint/pull/9655))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[node]` Move DBContext and DBProvider from the node package to the config
package. ([\#9655](https://github.com/tendermint/tendermint/pull/9655))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[rpc]` Remove global environment and replace with constructor
([\#9655](https://github.com/tendermint/tendermint/pull/9655))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- `[metrics]` Move state-syncing and block-syncing metrics to
their respective packages. Move labels from block_syncing
-> blocksync_syncing and state_syncing -> statesync_syncing
([\#9682](https://github.com/tendermint/tendermint/pull/9682))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[consensus]` ([\#386](https://github.com/cometbft/cometbft/pull/386)) Short-term fix for the case when `needProofBlock` cannot find previous block meta by defaulting to the creation of a new proof block. (@adizere)
- Special thanks to the [Vega.xyz](https://vega.xyz/) team, and in particular to Zohar (@ze97286), for reporting the problem and working with us to get to a fix.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[consensus]` Fixed a busy loop that happened when sending of a block part failed by sleeping in case of error.
([\#4](https://github.com/informalsystems/tendermint/pull/4))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[docker]` Ensure Docker image uses consistent version of Go.
([\#9462](https://github.com/tendermint/tendermint/pull/9462))
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/9717-abci-cli-fix-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[abci-cli]` Fix broken abci-cli help command.
([\#9717](https://github.com/tendermint/tendermint/pull/9717))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[config]` Introduce `BootstrapPeers` to the config to allow
nodes to list peers to be added to the addressbook upon start up.
([\#9680](https://github.com/tendermint/tendermint/pull/9680))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- `[proxy]` Introduce `NewUnsyncLocalClientCreator`, which allows local ABCI
clients to have the same concurrency model as remote clients (i.e. one
mutex per client "connection", for each of the four ABCI "connections").
([\#9830](https://github.com/tendermint/tendermint/pull/9830))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[tools/tm-signer-harness]` Remove the folder as it is unused
([\#136](https://github.com/cometbft/cometbft/issues/136))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[e2e]` Add functionality for uncoordinated (minor) upgrades
([\#56](https://github.com/tendermint/tendermint/pull/56))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[crypto/merkle]` Improve HashAlternatives performance
([\#6443](https://github.com/tendermint/tendermint/pull/6443))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[p2p/pex]` Improve addrBook.hash performance
([\#6509](https://github.com/tendermint/tendermint/pull/6509))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[crypto/merkle]` Improve HashAlternatives performance
([\#6513](https://github.com/tendermint/tendermint/pull/6513))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[pubsub]` Performance improvements for the event query API
([\#7319](https://github.com/tendermint/tendermint/pull/7319))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[rpc]` Enable caching of RPC responses
([\#9650](https://github.com/tendermint/tendermint/pull/9650))
62 changes: 49 additions & 13 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,27 @@
---
name: Bug report
about: Create a report to help us squash bugs!

labels: bug, needs-triage
---
<!--

Please fill in as much of the template below as you can.

If you have general questions, please create a new discussion:
https://github.com/tendermint/tendermint/discussions
https://github.com/cometbft/cometbft/discussions

Be ready for followup questions, and please respond in a timely manner. We might
ask you to provide additional logs and data (tendermint & app).
ask you to provide additional logs and data (CometBFT & App).

-->

**Tendermint version** (use `tendermint version` or `git rev-parse --verify HEAD` if installed from source):
## Bug Report

### Setup

**CometBFT version** (use `cometbft version` or `git rev-parse --verify HEAD` if installed from source):

**Have you tried the latest version**: yes/no

**ABCI app** (name for built-in, URL for self-written if it's publicly available):

Expand All @@ -25,23 +30,54 @@ ask you to provide additional logs and data (tendermint & app).
- **Install tools**:
- **Others**:

**node command runtime flags**:

**What happened**:
### Config

<!--

**What you expected to happen**:
You can paste only the changes you've made.

-->

**Have you tried the latest version**: yes/no
### What happened?

**How to reproduce it** (as minimally and precisely as possible):
### What did you expect to happen?

**Logs (paste a small part showing an error (< 10 lines) or link a pastebin, gist, etc. containing more of the log file)**:
### How to reproduce it

**Config (you can paste only the changes you've made)**:
<!--

**node command runtime flags**:
Provide a description here as minimally and precisely as possible as to how to
reproduce the issue. Ideally only using our kvstore application, as debugging
app chains is not within our team's scope.

-->

### Logs

<!--

**Please provide the output from the `http://<ip>:<port>/dump_consensus_state` RPC endpoint for consensus bugs**
Paste a small part showing an error (< 10 lines) or link a pastebin, gist, etc.
containing more of the log file).

-->

### `dump_consensus_state` output

<!--

Please provide the output from the `http://<ip>:<port>/dump_consensus_state` RPC
endpoint for consensus bugs.

-->

### Anything else we need to know

<!--

Is there any additional information not covered by the other sections that would
help us to triage/debug/fix this issue?

-->

**Anything else we need to know**:
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
blank_issues_enabled: true
contact_links:
- name: Ask a question
url: https://github.com/tendermint/tendermint/discussions
url: https://github.com/cometbft/cometbft/discussions
about: Please ask and answer questions here
14 changes: 8 additions & 6 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Feature request
about: Create a proposal to request a feature

labels: enhancement, needs-triage
---

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
Expand All @@ -11,17 +11,19 @@ v Word of caution: poorly thought-out proposals may be rejected
v without deliberation
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

## Summary
## Feature Request

### Summary

<!-- Short, concise description of the proposed feature -->

## Problem Definition
### Problem Definition

<!-- Why do we need this feature?
<!-- Why do we need this feature?
What problems may be addressed by introducing this feature?
What benefits does Tendermint stand to gain by including this feature?
What benefits does CometBFT stand to gain by including this feature?
Are there any disadvantages of including this feature? -->

## Proposal
### Proposal

<!-- Detailed description of requirements of implementation -->
14 changes: 7 additions & 7 deletions .github/ISSUE_TEMPLATE/proposal.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Protocol change proposal
about: Create a proposal to request a change to the protocol

labels: protocol-change, needs-triage
---

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
Expand All @@ -10,19 +10,19 @@ v Before smashing the submit button please review the template.
v Word of caution: Under-specified proposals may be rejected summarily
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

# Protocol Change Proposal
## Protocol Change Proposal

## Summary
### Summary

<!-- Short, concise description of the proposed change -->

## Problem Definition
### Problem Definition

<!-- Why do we need this change?
<!-- Why do we need this change?
What problems may be addressed by introducing this change?
What benefits does Tendermint stand to gain by including this change?
What benefits does CometBFT stand to gain by including this change?
Are there any disadvantages of including this change? -->

## Proposal
### Proposal

<!-- Detailed description of requirements of implementation -->
13 changes: 6 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,24 @@ If this PR is non-trivial/large/complex, please ensure that you have either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests. The team
can be reached via GitHub Discussions or the Cosmos Network Discord server in
the #tendermint-core channel. GitHub Discussions is preferred over Discord as it
the #cometbft channel. GitHub Discussions is preferred over Discord as it
allows us to keep track of conversations topically.
https://github.com/tendermint/tendermint/discussions
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current priorities, please
be advised that it may take some time before it is merged - especially if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/tendermint/projects/15/views/5
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated, or no tests needed
- [ ] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [ ] Updated relevant documentation (`docs/`) and code comments, or no
documentation updates needed
- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

25 changes: 0 additions & 25 deletions .github/codecov.yml

This file was deleted.

6 changes: 5 additions & 1 deletion .github/issue_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
---
labels: needs-triage
---

<!--

If you want to ask a general question, please create a new discussion instead of
an issue: https://github.com/tendermint/tendermint/discussions
an issue: https://github.com/cometbft/cometbft/discussions

-->
7 changes: 4 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.18"
go-version: "1.19"
- uses: actions/checkout@v3
- uses: technote-space/get-diff-action@v6
with:
Expand All @@ -32,6 +32,7 @@ jobs:
go.mod
go.sum
Makefile

- name: install
run: GOOS=${{ matrix.goos }} GOARCH=${{ matrix.goarch }} make build
if: "env.GIT_DIFF != ''"
Expand All @@ -43,7 +44,7 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.18"
go-version: "1.19"
- uses: actions/checkout@v3
- uses: technote-space/get-diff-action@v6
with:
Expand All @@ -65,7 +66,7 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.18"
go-version: "1.19"
- uses: actions/checkout@v3
- uses: technote-space/get-diff-action@v6
with:
Expand Down
Loading
0