Merge `main` into `feature/abci++vef` #407

sergio-mena · 2023-02-27T22:24:28Z

Contributes to #93

This is merging main into ABCI 2.0 feature branch feature/abci++vef just after the renaming is done.

Many conflicts, most of them were resolved by re-doing the renaming of top of the hunks that produced conflicts. Before creating this PR, the following was run locally (and passing):

make build
unit tests
e2e nightly

IMPORTANT: No need to review in detail: the changes seen here are those needed for the feature branch to be up to date with main (all reviewed in approved renaming PRs)

PR checklist

Tests written/updated
Changelog entry added in .changelog (we use unclog to manage our changelog)
Updated relevant documentation (docs/ or spec/) and code comments

Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Performed renaming in docker-related files * Fix e2e launch * one more

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.11.0 to 1.12.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/e433c27a7eacc2e54ffb3895663a425829563ef9"><code>e433c27</code></a> Release v1.12.0 (<a href="https://github-redirect.dependabot.com/bufbuild/buf-setup-action/issues/95">#95</a>)</li> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/3aad079f90cfc1fdaed6ca6b1aa3c60de44018b5"><code>3aad079</code></a> Support netrc-based credentials in buf-setup-action (<a href="https://github-redirect.dependabot.com/bufbuild/buf-setup-action/issues/94">#94</a>)</li> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/6847859a0077eb27aaf74d4e48fe451959da1665"><code>6847859</code></a> Update dependencies and rebuild (<a href="https://github-redirect.dependabot.com/bufbuild/buf-setup-action/issues/93">#93</a>)</li> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/4b89ef3fddf743121a6b1fbf5013eb4f2bc5ca1f"><code>4b89ef3</code></a> TCN-875 Resolve sync v1 branch bug (<a href="https://github-redirect.dependabot.com/bufbuild/buf-setup-action/issues/92">#92</a>)</li> <li>See full diff in <a href="https://github.com/bufbuild/buf-setup-action/compare/v1.11.0...v1.12.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=bufbuild/buf-setup-action&package-manager=github_actions&previous-version=1.11.0&new-version=1.12.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.51.0 to 1.52.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p> <blockquote> <h2>Release 1.52.0</h2> <h1>New Features</h1> <ul> <li>xdsclient: log node ID with verbosity INFO (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5860">#5860</a>)</li> <li>ringhash: impose cap on <code>max_ring_size</code> to reduce possibility of OOMs (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5801">#5801</a>)</li> </ul> <h1>Behavior Changes</h1> <ul> <li>client: return an error from <code>Dial</code> if an empty target is passed and no custom dialer is present; the ClientConn would otherwise be unable to connect and perform RPCs (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5732">#5732</a>) <ul> <li>Special Thanks: <a href="https://github.com/huangchong94"><code>@huangchong94</code></a></li> </ul> </li> </ul> <h1>Bug Fixes</h1> <ul> <li>transport (net/http server handler): respond to bad HTTP requests with status 400 (Bad Request) instead of 500 (Internal Server Error). (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5804">#5804</a>) <ul> <li>Special Thanks: <a href="https://github.com/sjbarag"><code>@sjbarag</code></a></li> </ul> </li> <li>transport: Fixed closing a closed channel panic in handlePing (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5854">#5854</a>)</li> <li>server: fix ChainUnaryInterceptor and ChainStreamInterceptor to allow retrying handlers (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5666">#5666</a>) <ul> <li>Special Thanks: <a href="https://github.com/yiminc"><code>@yiminc</code></a></li> </ul> </li> <li>transport: ensure value of <code>:authority</code> header matches server name used in TLS handshake when the latter is overridden by the name resolver (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5748">#5748</a>) <ul> <li>Special Thanks: <a href="https://github.com/holdno"><code>@holdno</code></a></li> </ul> </li> </ul> <h1>Documentation</h1> <ul> <li>examples: add an example to illustrate the usage of stats handler (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5657">#5657</a>) <ul> <li>Special Thanks: <a href="https://github.com/Yash-Handa"><code>@Yash-Handa</code></a></li> </ul> </li> <li>examples: add new example to show updating metadata in interceptors (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5788">#5788</a>) <ul> <li>Special Thanks: <a href="https://github.com/richzw"><code>@richzw</code></a></li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/grpc/grpc-go/commit/ce56cefc0cc80503d7f8de1e1ec1af3cb741fbd7"><code>ce56cef</code></a> Change version to 1.52.0 (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5870">#5870</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/a0e8eb9dc4111cd4d8dc52bc89cd733e5630fc0c"><code>a0e8eb9</code></a> test: rename race.go to race_test.go (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5869">#5869</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/ae86ff40e723905d1d7f084405a7ed6e9a5265e1"><code>ae86ff4</code></a> benchmark: fix typo in ClientReadBufferSize feature name (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5867">#5867</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/e53d28f5eb19a6816d4bb5c3db1b793ac2ba3e49"><code>e53d28f</code></a> xdsclient: log node ID with verbosity INFO (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5860">#5860</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/9373e5cb26f0e34c1b5fa54f1ba712979b54d661"><code>9373e5c</code></a> transport: Fix closing a closed channel panic in handlePing (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5854">#5854</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/2f413c454850afdb19a685fdee95c5d7701891ab"><code>2f413c4</code></a> transport/http2: use HTTP 400 for bad requests instead of 500 (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5804">#5804</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/5003029eb684a60a7a84aad3ad498d7bf1e44628"><code>5003029</code></a> testutils: do a better job of verifying pick_first in tests (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5850">#5850</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/3e27f89917e8092469db2709c5d726acaaa2396e"><code>3e27f89</code></a> binarylog: Account for key in metadata truncation (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5851">#5851</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/f54bba9af73267dcc87fcc4841dfa1e0de39d332"><code>f54bba9</code></a> test/xds: minor cleanup in xDS e2e test (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5843">#5843</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/a9709c3f8cfe5f22703b8cfebd83d3996f8fbb33"><code>a9709c3</code></a> Added logs for reasons causing connection and transport close (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5840">#5840</a>)</li> <li>Additional commits viewable in <a href="https://github.com/grpc/grpc-go/compare/v1.51.0...v1.52.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google.golang.org/grpc&package-manager=go_modules&previous-version=1.51.0&new-version=1.52.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.11.0 to 1.12.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf/releases">github.com/bufbuild/buf's releases</a>.</em></p> <blockquote> <h2>v1.12.0</h2> <h2>What's Changed</h2> <ul> <li>Add <code>buf curl</code> command to invoke RPCs via <a href="https://connect-build">Connect</a>, <a href="https://grpc.io/">gRPC</a>, or <a href="https://github.com/grpc/grpc-web.">gRPC-Web</a></li> <li>Introduce <code>objc_class_prefix</code> option in managed mode, allowing a <code>default</code> value for <code>objc_class_prefix</code> for all files, <code>except</code> and <code>override</code>, which both behave similarly to other <code>except</code> and <code>override</code> options. Specifying an empty <code>default</code> value is equivalent to having managed mode on in previous versions.</li> <li>Introduce <code>ruby_package</code> option in managed mode, allowing <code>except</code> and <code>override</code>, in the same style as <code>objc_class_prefix</code>. Leaving <code>ruby_package</code> unspecified has the same effect as having mananged mode enabled in previous versions.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/bufbuild/buf/compare/v1.11.0...v1.12.0">https://github.com/bufbuild/buf/compare/v1.11.0...v1.12.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf/blob/main/CHANGELOG.md">github.com/bufbuild/buf's changelog</a>.</em></p> <blockquote> <h2>[v1.12.0] - 2023-01-12</h2> <ul> <li>Add <code>buf curl</code> command to invoke RPCs via <a href="https://connect-build">Connect</a>, <a href="https://grpc.io/">gRPC</a>, or <a href="https://github.com/grpc/grpc-web.">gRPC-Web</a></li> <li>Introduce <code>objc_class_prefix</code> option in managed mode, allowing a <code>default</code> value for <code>objc_class_prefix</code> for all files, <code>except</code> and <code>override</code>, which both behave similarly to other <code>except</code> and <code>override</code> options. Specifying an empty <code>default</code> value is equivalent to having managed mode on in previous versions.</li> <li>Introduce <code>ruby_package</code> option in managed mode, allowing <code>except</code> and <code>override</code>, in the same style as <code>objc_class_prefix</code>. Leaving <code>ruby_package</code> unspecified has the same effect as having mananged mode enabled in previous versions.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf/commit/58ba9bbc8640dddb263b1d6ce7dc8f777f6f8e19"><code>58ba9bb</code></a> Release v1.12.0 (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1726">#1726</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/7f42ba1d83c4ffee5c77b6ae7d3bfc516ec908c1"><code>7f42ba1</code></a> Use protoencoding for marshal/unmarshal in bufcurl and turn off pretty printi...</li> <li><a href="https://github.com/bufbuild/buf/commit/839a29eaa3afce19e25ff96e4020c81a47812699"><code>839a29e</code></a> Remove auto value from reflect protocol and make unset the default (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1705">#1705</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/2a507fad99a41caa1c80c8ec2cd6d6662efe0a12"><code>2a507fa</code></a> Add scala to plugin output lang enum (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1722">#1722</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/8cac1d5749a630d9b7c233821a795c399ba75780"><code>8cac1d5</code></a> Make silent runners faster (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1713">#1713</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/f94d9bfc887527e7457ff2e7483ce11bafbe0c75"><code>f94d9bf</code></a> update makego (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1714">#1714</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/5d03706419e91297ab2738e03de97f9abf359634"><code>5d03706</code></a> Update license header for 2023 (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1712">#1712</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/3343502e9fd9e9d5a4818a503cfee034cd652759"><code>3343502</code></a> Add plugin delete command (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1711">#1711</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/2f0804d6767505a43aeb74828e16d99abb9bebeb"><code>2f0804d</code></a> don't use remote package (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1710">#1710</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/f5dd847fb18b577a62aaf46dd168b6e5b25206a3"><code>f5dd847</code></a> Bump bufbuild/buf-setup-action from 1.9.0 to 1.11.0 (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1706">#1706</a>)</li> <li>Additional commits viewable in <a href="https://github.com/bufbuild/buf/compare/v1.11.0...v1.12.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/bufbuild/buf&package-manager=go_modules&previous-version=1.11.0&new-version=1.12.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

* Renaming of variables and aliases prefixed with tm to use prefix cmt * Update assert to reflect new alias * More renaming * updating the Style guide to reflect new aliases * Replacing references to alias in the documentation

* Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over * Linter error

I noticed that stalebot wasn't respecting our `wip` label, only to realize I hadn't yet updated its config. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed

#151)

* Porting 0.38.0 changelog to unclog. * redirecting unclog to cometbft repo * Rename files with unreleased changes * fixing issue number * Update .changelog/epilogue.md Co-authored-by: Thane Thomson <connect@thanethomson.com> * Update .changelog/epilogue.md Co-authored-by: Thane Thomson <connect@thanethomson.com> * Add generated CHANGELOG.md. This will need to be generated again to include changes released with v0.37.0 Co-authored-by: Thane Thomson <connect@thanethomson.com>

Follows from #121 (comment) This PR also renames the `linter.yml` workflow to `markdown-linter.yml` to disambiguate it from the Go linter workflow. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed

* Updated README to reflect renaming * Added comment on TM version compatibility

* Replace tm-db with cometbft-db Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Update build workflow to use private cometbft-db repo Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Build Docker image on PRs to ensure this works Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for E2E workflows Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for mock generation check Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for tests Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Cosmetic update to build workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for vulncheck Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for linter Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Build Docker image on PRs to ensure this works Signed-off-by: Thane Thomson <connect@thanethomson.com> * docker: Add support for usage of cometbft-db as private module Signed-off-by: Thane Thomson <connect@thanethomson.com> * Replace TENDERMINT_BUILD_OPTIONS with COMETBFT_BUILD_OPTIONS to fix building of database support Signed-off-by: Thane Thomson <connect@thanethomson.com> * deps: Update cometbft-db to latest unreleased commit Signed-off-by: Thane Thomson <connect@thanethomson.com> * deps: Update cometbft-db to latest unreleased commit Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump cometbft-db version to v0.7.0 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Minor formatting fixes Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>

* [forward-ported] Renamed all help text for cometbft CLI * Extra renaming needed on `main` * [forward port] Update networks/local/localnode/Dockerfile Co-authored-by: Thane Thomson <connect@thanethomson.com> * Update cmd/tendermint/commands/debug/kill.go Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>

Follow-up to #137. Fixes the Docker builds that were failing to be parsed by GitHub Actions. Also fixes our `make build-docker` target to build images in the same way we do in CI. On Linux, I have to explicitly tell Docker to use BuildKit to pass the target/build platform args in: ```bash DOCKER_BUILDKIT=1 make build-docker ``` Given that I've also proven now that the images do build in CI (see [this workflow](https://github.com/cometbft/cometbft/actions/runs/3964436268/jobs/6793294390) and [this one](https://github.com/cometbft/cometbft/actions/runs/3964436273/jobs/6793294238)), we no longer need to build on every change to every pull request. The E2E node Docker image in particular takes nearly 30mins to build, so that would slow us down tremendously. It's far better to build those images only once PRs get merged. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed

@lasarojc

I released tm-load-test v1.3.0 earlier (see https://github.com/informalsystems/tm-load-test/releases/tag/v1.3.0) to remove its dependency on Tendermint Core. cc @lasarojc --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed

* make proto-gen on main Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Show git diffs when generated code check fails Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Remove unnecessary buf installation step Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Remove unnecessary protoc-gen-gogofaster install command Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Add Buf API token for linting of private repos Signed-off-by: Thane Thomson <connect@thanethomson.com> * debug: Try check which version of protoc-gen-gogofaster is installed Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert "debug: Try check which version of protoc-gen-gogofaster is installed" This reverts commit 0204310. * debug: Display Go and Buf versions on failure Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert "debug: Display Go and Buf versions on failure" This reverts commit 86dc450. * ci: Remove tools/path config from proto check Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Add tokens to appease Buf in proto linting workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Fix buf API token param name Signed-off-by: Thane Thomson <connect@thanethomson.com> * debug: Attempt to use Go 1.19 in CI Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>

* spec: renaming Tendermint to CometBFT * CometBFT's consensus protocol is called Tendermint, so this use has been preserved. * spec: initial renaming Tendermint to CometBFT * spec: renaming Tendermint to CometBFT in /spec/p2p * spec/rename: links to CometBFT repo in /spec/ * spec/rename: repository links in /spec/light-client * spec/rename: Tendermint to CometBFT in /spec/abci * spec/rename: further renaming of links * spec/rename: Tendermint consensus protocol of CometBFT * spec/rename: Tendermint -> CometBFT Socket Protocol * spec/rename: Tendermint as a consensus algorithm * spec/rename: replacing some Go documentation links * spec/rename: TMHOME -> CMTHOME, go-amino removed * spec/rename: Tendermint -> Cosmos blockchain * Also applies for full node, light node, security and failure model * spec/rename: tags renamed TMBC -> CMBC * spec: renaming Tendermint to CometBFT * CometBFT's consensus protocol is called Tendermint, so this use has been preserved. * spec: initial renaming Tendermint to CometBFT * spec: renaming Tendermint to CometBFT in /spec/p2p * spec/rename: links to CometBFT repo in /spec/ * spec/rename: repository links in /spec/light-client * spec/rename: Tendermint to CometBFT in /spec/abci * spec/rename: further renaming of links * spec/rename: Tendermint consensus protocol of CometBFT * spec/rename: Tendermint -> CometBFT Socket Protocol * spec/rename: Tendermint as a consensus algorithm * spec/rename: replacing some Go documentation links * spec/rename: TMHOME -> CMTHOME, go-amino removed * spec/rename: Tendermint -> Cosmos blockchain * Also applies for full node, light node, security and failure model * spec/rename: tags renamed TMBC -> CMBC * spec/rename: Tendermint -> Cosmos security model * spec/rename: fixing mismatch CometBFT/Tendermint/consensus * spec/rename: Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems>

* search and replace of tendermint/tendermint, ignoring legitimate links to the TM repo * search and replace of tendermint/tendermint, ignoring legitimate links to the TM repo, for tests * update the go.mod file * use informal's tm-db until cometbft-db releases * update Makefile to point to renamed repo * Use tm-load-test without circular dependency * updating mocks * placate linter * go mod tidy * debugging error in test * Fix org and repo in generated files * Fix org and repo in generated files * Fixing protobuf file descriptors with make proto-gen * Reverting changes in references to issues/PR * make proto-gen Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert "make proto-gen" This reverts commit 87ed597. * debug: Show git diff output when check-generated workflow fails Signed-off-by: Thane Thomson <connect@thanethomson.com> * debug: Check protoc version in CI Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert "debug: Check protoc version in CI" This reverts commit 17a0eb7. * debug: Try enforcing install of latest buf version Signed-off-by: Thane Thomson <connect@thanethomson.com> * debug: Explicitly install cosmos/gogoproto v1.4.3 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert "debug: Explicitly install cosmos/gogoproto v1.4.3" This reverts commit 34eeb25. Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>

* tools: remove tm-signer-harness * Added changelog entry for tm-signer-harness folder removal

Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Replace references to tm * Fix bft name * Applied PR comments * replace tag * Apply suggestions from code review Co-authored-by: Daniel <daniel.cason@informal.systems> * Removed Core after cometbft * removed amino mentioning from doc * Apply suggestions from code review Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Daniel <daniel.cason@informal.systems> * Updated files based on PR review Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Renames cmd/tendermint to cmd/cometbft * Replacing TMHOME for CMTHOME. On reading the environment variable we still try TMHOME if CMTHOME is not found. TMHOME is deprecated and will be removed in the future releases. * Include TMHOME deprecation in the changelog * Updating the config * updating uses of .tendermint to .cometbft * Updating the Makefile * Fix test of debug level flags. * Update .changelog/unreleased/breaking-changes/211-deprecate-tmhome.md Co-authored-by: Thane Thomson <connect@thanethomson.com> --------- Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Fix multiversion e2e when `version <= v0.34.24` * Changes we want no matter what we do * Approach 1: With docker-compose up recreating image * Revert "Approach 1: With docker-compose up recreating image" This reverts commit 068f5b78d3b7cf99fb21296707117e4f4e2ef3e0. * Approach 2: With distinct docker-compose service * Fix the case when 'upgrade' is not the last perturbation * Update generator * Simplify template * bump * Update test/e2e/pkg/manifest.go * changelog * doc * fix doc

* add peer gossip sleep * add changelog * Update .changelog/unreleased/bug-fixes/4-busy-loop-send-block-part.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Update .changelog/unreleased/bug-fixes/4-busy-loop-send-block-part.md --------- Co-authored-by: jhernandezb <contact@jhernandez.me> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>

…321) Minor tweak to the README to reflect test/lint status on release branches (arguably more interesting to users than the test/linter status on the `main` branch, which we discourage people from using directly). [Rendered](https://github.com/cometbft/cometbft/blob/thane/update-readme-branch-tests/README.md) --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed

* Text fixed -"Methods" section fixed to consider locked value. * File with extra scenarios added * Text fixed to not mention locked value * Grammar fixed * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_methods.md * file with scenarios integrated * renaming Tendermint->CometBFT done * Apply suggestions from code review Co-authored-by: Daniel <daniel.cason@informal.systems> * Fixed PR's comments: -fixed daniel's and lasaro's comments -renamed abci++_tmint_expected_behavior.md to abci++_comet_expected_behavior.md --------- Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel <daniel.cason@informal.systems>

by moving the `codecov.yml` file from .github the root folder. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

* Upgrade to Go 1.19 on main Signed-off-by: Thane Thomson <connect@thanethomson.com> * Run proto-gen with the right go version * Updating the net dependency * Force a specific go version for vul-check. Should be reverted to not specifying the patch number. * Revert to using just the major version number. * Forcing go-vulcheck to use 1.19.6, since it is not picking it by setting just 1.19. This hould be reverted later. --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.6.0 to 0.7.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/8e2b117aee74f6b86c207a808b0255de45c0a18a"><code>8e2b117</code></a> http2/hpack: avoid quadratic complexity in hpack decoding</li> <li><a href="https://github.com/golang/net/commit/547e7edf3873d6f3a9c093d3785f9e2289e00746"><code>547e7ed</code></a> http2: avoid referencing ResponseWrite.Write parameter after returning</li> <li><a href="https://github.com/golang/net/commit/39940adcaaa73e661124cb80fb8dd57ea929dbaf"><code>39940ad</code></a> html: parse comments per HTML spec</li> <li>See full diff in <a href="https://github.com/golang/net/compare/v0.6.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.6.0&new-version=0.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

…51.2 (#359) [//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.51.1 to 1.51.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases">github.com/golangci/golangci-lint's releases</a>.</em></p> <blockquote> <h2>v1.51.2</h2> <h2>Changelog</h2> <ul> <li>589ab848 build(deps): bump github.com/ashanbrown/forbidigo from 1.3.0 to 1.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3590">#3590</a>)</li> <li>c4df01f8 build(deps): bump github.com/bombsimon/wsl/v3 from 3.3.0 to 3.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3575">#3575</a>)</li> <li>b19c0f1c build(deps): bump github.com/daixiang0/gci from 0.9.0 to 0.9.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3576">#3576</a>)</li> <li>a775985f build(deps): bump github.com/go-critic/go-critic from 0.6.5 to 0.6.6 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3616">#3616</a>)</li> <li>3e8facb4 build(deps): bump github.com/go-critic/go-critic from 0.6.6 to 0.6.7 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3618">#3618</a>)</li> <li>b8907fa0 build(deps): bump github.com/junk1tm/musttag from 0.4.4 to 0.4.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3598">#3598</a>)</li> <li>ed098c43 build(deps): bump github.com/polyfloyd/go-errorlint from 1.0.6 to 1.1.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3588">#3588</a>)</li> <li>64374294 build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.21.1 to 1.22.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3574">#3574</a>)</li> <li>ba76af42 build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.22.0 to 1.23.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3615">#3615</a>)</li> <li>1248a2b6 build(deps): bump github.com/securego/gosec/v2 from 2.14.0 to 2.15.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3577">#3577</a>)</li> <li>dd45e448 build(deps): bump golang.org/x/tools from 0.5.0 to 0.6.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3587">#3587</a>)</li> <li>a4d2f893 build(deps): bump honnef.co/go/tools from 0.4.0 to 0.4.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3591">#3591</a>)</li> <li>f7642347 build(deps): bump honnef.co/go/tools from 0.4.1 to 0.4.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3599">#3599</a>)</li> <li>fe53ca0c fix: cache status size calculation (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3611">#3611</a>)</li> <li>a0893e32 govet: enable timeformat by default (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3602">#3602</a>)</li> </ul> <hr /> <p>golangci-lint is a free and open-source project, built by people in their free time. Also, the <a href="https://golangci-lint.run/product/thanks/">linter authors</a> are an important part of golangci-lint. If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linter authors). ❤️</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md">github.com/golangci/golangci-lint's changelog</a>.</em></p> <blockquote> <h3>v1.51.2</h3> <ol> <li>updated linters <ul> <li><code>forbidigo</code>: from 1.3.0 to 1.4.0</li> <li><code>gci</code>: from 0.9.0 to 0.9.1</li> <li><code>go-critic</code>: from 0.6.5 to 0.6.7</li> <li><code>go-errorlint</code>: from 1.0.6 to 1.1.0</li> <li><code>gosec</code>: from 2.14.0 to 2.15.0</li> <li><code>musttag</code>: from 0.4.4 to 0.4.5</li> <li><code>staticcheck</code>: from 0.4.0 to 0.4.2</li> <li><code>tools</code>: from 0.5.0 to 0.6.0</li> <li><code>usestdlibvars</code>: from 1.21.1 to 1.23.0</li> <li><code>wsl</code>: from 3.3.0 to 3.4.0</li> <li><code>govet</code>: enable <code>timeformat</code> by default</li> </ul> </li> <li>misc. <ul> <li>fix: cache status size calculation</li> <li>add new source archive</li> </ul> </li> <li>Documentation <ul> <li>Improve installation section</li> <li>Replace links to godoc.org with pkg.go.dev</li> </ul> </li> </ol> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint/commit/3e8facb4949586ba9e5dccdd2f9f0fe727a5e335"><code>3e8facb</code></a> build(deps): bump github.com/go-critic/go-critic from 0.6.6 to 0.6.7 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3618">#3618</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/a775985f5de48506c957e10b5609e33733bcd978"><code>a775985</code></a> build(deps): bump github.com/go-critic/go-critic from 0.6.5 to 0.6.6 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3616">#3616</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/ba76af423f3e8feec79ce0a575a9cd72708b75fd"><code>ba76af4</code></a> build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.22.0 to 1.23...</li> <li><a href="https://github.com/golangci/golangci-lint/commit/defde13179d461f2e3f2657d8878fb81605b7d2f"><code>defde13</code></a> doc: improve installation section (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3610">#3610</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/fe53ca0cd4e99d155325c7b7c1f1f733951af5ab"><code>fe53ca0</code></a> fix: cache status size calculation (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3611">#3611</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/e23ac00430fc0a4e1025aba023ab2953d08a8836"><code>e23ac00</code></a> dev: remove duplicated test asserts (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3608">#3608</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/69e54817aa9d610e60f3ecdf8fd9867876297432"><code>69e5481</code></a> dev: add new source archive (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3585">#3585</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/a0893e326819544bc9340da0258ea9e5b0c9f15c"><code>a0893e3</code></a> govet: enable timeformat by default (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3602">#3602</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/f76423477700fc49c7c783a643990fe49130b4a1"><code>f764234</code></a> build(deps): bump honnef.co/go/tools from 0.4.1 to 0.4.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3599">#3599</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/b8907fa0ff23a8467abbb79d07cc6db7879e8aa4"><code>b8907fa</code></a> build(deps): bump github.com/junk1tm/musttag from 0.4.4 to 0.4.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3598">#3598</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.51.1...v1.51.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/golangci/golangci-lint&package-manager=go_modules&previous-version=1.51.1&new-version=1.51.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

#345) (#362) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run

* remove mempoolReactor from node; remove unused wrappers * Remove pexReactor from node * Remove unused return value

* fixing broken link quick-start (#319) * fix link to point to relative page (#319) * fix link to point to rpc page (#319) * fix link that works for rpc (#319) * adding front matter to trigger hooks (#319) * add frontmatter to adr page (#319) * make link to configuration page relative (#319) * remove irrelevant text (#319) * updating relative link and removing irrelevant text (#319) * remove front matter from ADR (#319) * fixing broken links unders docs/tools (#319) * fixing broken links under spec/core (#319) * fixing broken links in spec/abci home (#319) * fix uparrows rendering and broken links (#319) * fixing links, comments on abci methods (#319) * fixing links in tutorials (#319) * adding a landing page for Apps (#319) * renaming qa v0.34 page to show in navigation (#319) * rename title of page for navigation (#319) * fixing links on abci client server (#319) * changes to allow RPC top level navigation on docs site (#319) * fixing some more broken references (#319) * reverting link change as per review (#319) * reverting link change as per review (#319) * reverting link in app-dev as per review (#319)

* ci: Remove Buf tokens from workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * Format proto folder readme to trigger workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Remove mempool/v1 * Remove all mempool versions * Remove TTLDuration and TTLNumBlocks * Remove fields in ResponseCheckTx * Remove unused variable * Move test/fuzz/mempool/v0 * Undo adding incorrect file * Update changelog * Move makeBlocks to consensus; remove unused functions * move mempool/v0 to mempool * Update UPGRADING.md * Revert removing proto fields; mark them as reserved * Add comment about versions to MempoolConfig --------- Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Add Prometheus and PrometheusListenAddr flags * Add Prometheus flag at root level, for all nodes * Add comment * Add PrometheusProxyPort; remove PrometheusListenAddr * Update startup log message * Update startup log message * Don't print the whole line in docker template * Remove flag from ManifestNode * Do not generate PrometheusProxyPort if config is disabled

[QA docs README rendered](https://github.com/cometbft/cometbft/blob/lasarojc/qa_0.37.x-alpha3/docs/qa/README.md) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

#387) * changelog * Added log and short-circuit in needProofBlock

Contributes to #93 and #41 [Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md) Complementary to #376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts. The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

jmalicevic · 2023-02-28T07:58:32Z

config/config.go

-		MaxTxsBytes:  1024 * 1024 * 1024, // 1GB
-		CacheSize:    10000,
-		MaxTxBytes:   1024 * 1024, // 1MB
-		TTLDuration:  0 * time.Second,


I assume there were removed in a separate PR?

Yes, this comes from @hvanz's work on removing the priority mempool, the PR is #281

cason

My review covers the /spec/ and /docs directories, plus some Markdown files throughout the repository.

The adopted criterion is that the main branch contains the reference content. The differences, in this case, are minor, due to the snapshot considered in this merge.

thanethomson and others added 30 commits January 13, 2023 13:39

go mod tidy (#104)

8b95237

Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>

Renaming in docker-related files (#110)

d9cae0c

* Performed renaming in docker-related files * Fix e2e launch * one more

replace tm for cmt (#101)

88cbf47

* Renaming of variables and aliases prefixed with tm to use prefix cmt * Update assert to reflect new alias * More renaming * updating the Style guide to reflect new aliases * Replacing references to alias in the documentation

Fix e2e nightlies in CI, broken by #110 (#138)

fc48e6f

* Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over * Linter error

Rename inside test/e2e (#139)

dca9ecf

Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebase (

6365333

#151)

Revert cometbft-proof to tendermint-proof (#149)

a3221e5

Updated README to reflect renaming (#121)

af3bc47

* Updated README to reflect renaming * Added comment on TM version compatibility

tools: remove tm-signer-harness (#177)

1587e95

* tools: remove tm-signer-harness * Added changelog entry for tm-signer-harness folder removal

ci: Remove docs build/deploy workflow (#188)

a8e67cc

Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>

Fixes the and removes other networks. (#200)

5d54939

Renamed prefix in command (#237)

c25484f

thanethomson and others added 17 commits February 15, 2023 10:43

Remove MBT section from contributing guidelines (#343)

ba097ec

Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>

Remove unused code (#286)

a2d9915

* remove mempoolReactor from node; remove unused wrappers * Remove pexReactor from node * Remove unused return value

Don't specify the patch version in go-vulncheck (#369)

280f4b9

Short-term fix for needProofBlock problem based on the main branch (

28b130f

#387) * changelog * Added log and short-circuit in needProofBlock

sergio-mena requested review from a team as code owners February 27, 2023 22:24

sergio-mena self-assigned this Feb 27, 2023

sergio-mena added the rename Renaming our fork label Feb 27, 2023

sergio-mena mentioned this pull request Feb 27, 2023

Rename to cometbft #93

Closed

44 tasks

jmalicevic reviewed Feb 28, 2023

View reviewed changes

jmalicevic approved these changes Feb 28, 2023

View reviewed changes

Merge branch main into feature/abci++vef

bd9d7e9

sergio-mena force-pushed the sergio/merge-main-into-abci++vef branch from 9929325 to bd9d7e9 Compare February 28, 2023 09:45

jmalicevic mentioned this pull request Feb 28, 2023

spec:ABCI2.0 - Uncommenting content related to vote xtensions and finalize block #421

Merged

cason approved these changes Mar 1, 2023

View reviewed changes

sergio-mena merged commit bd9d7e9 into feature/abci++vef Mar 1, 2023

sergio-mena deleted the sergio/merge-main-into-abci++vef branch March 1, 2023 11:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge `main` into `feature/abci++vef` #407

Merge `main` into `feature/abci++vef` #407

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Merge main into feature/abci++vef #407

Merge main into feature/abci++vef #407

Uh oh!

Conversation

PR checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Merge `main` into `feature/abci++vef` #407

Merge `main` into `feature/abci++vef` #407