8000 chore: relax Go version constraint to 1.23 (backport #4964) by mergify[bot] · Pull Request #4965 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: relax Go version constraint to 1.23 (backport #4964) #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Feb 20, 2025

This PR relaxes to Go version from 1.23 from 1.23.5. This should implicitly use the latest patch version by default, but let dependent modules control of the patch model. Although it's recommended that the latest patch is used in general.

This avoids the need to constantly update this value on every Go patch upgrade.

Similar change done in cometbft-db here (cometbft/cometbft-db#245)


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

This is an automatic backport of pull request #4964 done by [Mergify](https://mergify.com).

This PR relaxes to Go version from 1.23 from 1.23.5. This should
implicitly use the latest patch version by default, but let dependent
modules control of the patch model. Although it's recommended that the
latest patch is used in general.

This avoids the need to constantly update this value on every Go patch
upgrade.

Similar change done in cometbft-db here
(cometbft/cometbft-db#245)

---

#### PR checklist

- [x] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments

(cherry picked from commit a8b48c7)

# Conflicts:
#	test/e2e/docker/Dockerfile
#	test/e2e/docker/Dockerfile.debug
@mergify mergify bot requested a review from a team as a code owner February 20, 2025 22:25
@mergify mergify bot requested a review from a team February 20, 2025 22:25
@mergify mergify bot requested a review from a team as a code owner February 20, 2025 22:25
@mergify mergify bot added the conflicts label Feb 20, 2025
Copy link
Contributor Author
mergify bot commented Feb 20, 2025

Cherry-pick of a8b48c7 has failed:

On branch mergify/bp/v1.x/pr-4964
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit a8b48c7e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/go-version.env
	modified:   DOCKER/Dockerfile
	modified:   README.md
	modified:   api/go.mod
	modified:   docs/tutorials/go-built-in.md
	modified:   docs/tutorials/go.md
	modified:   go.mod
	modified:   go.work

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/e2e/docker/Dockerfile
	both modified:   test/e2e/docker/Dockerfile.debug

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@zrbecker zrbecker merged commit 4510321 into v1.x Feb 24, 2025
21 checks passed
@zrbecker zrbecker deleted the mergify/bp/v1.x/pr-4964 branch February 24, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0