chore: relax Go version constraint to 1.23 #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 76.80% 76.97% +0.16%
==========================================
Files 23 23
Lines 2048 2076 +28
==========================================
+ Hits 1573 1598 +25
- Misses 403 405 +2
- Partials 72 73 +1 |
jmalicevic
approved these changes
Feb 19, 2025
3 tasks
github-merge-queue bot
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Feb 20, 2025
This PR relaxes to Go version from 1.23 from 1.23.5. This should implicitly use the latest patch version by default, but let dependent modules control of the patch model. Although it's recommended that the latest patch is used in general. This avoids the need to constantly update this value on every Go patch upgrade. Similar change done in cometbft-db here (cometbft/cometbft-db#245) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
mergify bot
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Feb 20, 2025
This PR relaxes to Go version from 1.23 from 1.23.5. This should implicitly use the latest patch version by default, but let dependent modules control of the patch model. Although it's recommended that the latest patch is used in general. This avoids the need to constantly update this value on every Go patch upgrade. Similar change done in cometbft-db here (cometbft/cometbft-db#245) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit a8b48c7) # Conflicts: # test/e2e/docker/Dockerfile # test/e2e/docker/Dockerfile.debug
3 tasks
mergify bot
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Feb 20, 2025
This PR relaxes to Go version from 1.23 from 1.23.5. This should implicitly use the latest patch version by default, but let dependent modules control of the patch model. Although it's recommended that the latest patch is used in general. This avoids the need to constantly update this value on every Go patch upgrade. Similar change done in cometbft-db here (cometbft/cometbft-db#245) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit a8b48c7) # Conflicts: # .github/workflows/go-version.env # DOCKER/Dockerfile # README.md # api/go.mod # docs/guides/go-built-in.md # docs/guides/go.md # go.mod # go.work # test/e2e/docker/Dockerfile # test/e2e/docker/Dockerfile.debug
3 tasks
zrbecker
added a commit
to cometbft/cometbft
that referenced
this pull request
Feb 24, 2025
This PR relaxes to Go version from 1.23 from 1.23.5. This should implicitly use the latest patch version by default, but let dependent modules control of the patch model. Although it's recommended that the latest patch is used in general. This avoids the need to constantly update this value on every Go patch upgrade. Similar change done in cometbft-db here (cometbft/cometbft-db#245) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4964 done by [Mergify](https://mergify.com). --------- Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
Solovyov1796
pushed a commit
to 0glabs/cometbft
that referenced
this pull request
Apr 10, 2025
This PR relaxes to Go version from 1.23 from 1.23.5. This should implicitly use the latest patch version by default, but let dependent modules control of the patch model. Although it's recommended that the latest patch is used in general. This avoids the need to constantly update this value on every Go patch upgrade. Similar change done in cometbft-db here (cometbft/cometbft-db#245) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4964 done by [Mergify](https://mergify.com). --------- Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the Go restraint to 1.23. In modules that include it, it will require 1.23, but will be flexible to the patch version that module is on.
I removed the Github Action env variable since it doesn't look like we use it anymore. Perhaps in the recent Github Action refactors we removed it's usage. (If workflows start failing I will need to restore this, but I can't find any references to it in the code).
PR checklist
.changelog(we use unclog to manage our changelog)