8000 Fixed using the simple way suggested by JayGaba · Pull Request #547 · configu/configu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed using the simple way suggested #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

JayGaba
Copy link
Contributor
@JayGaba JayGaba commented Oct 11, 2024

The fix ensures integration bundle creates only one-file by adding splitting: false, to every tsup.config.ts file.

@JayGaba
Copy link
Contributor Author
JayGaba commented Oct 11, 2024

#Closes #535

@JayGaba
Copy link
Contributor Author
JayGaba commented Oct 11, 2024

@davidmeirlevy please review and merge, thanks!

Copy link
Contributor
@davidmeirlevy davidmeirlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
Just one change and we can merge.

@davidmeirlevy davidmeirlevy linked an issue Oct 11, 2024 that may be closed by this pull request
Made changes as suggested
@JayGaba JayGaba requested a review from davidmeirlevy October 11, 2024 21:08
@davidmeirlevy
Copy link
Contributor

It seems like the lock file should be updated accordingly.
Please run "pnpm install" to create a new lock file, and commit it, so the CI could pass.

@JayGaba
Copy link
Contributor Author
JayGaba commented Oct 12, 2024

It seems like the lock file should be updated accordingly. Please run "pnpm install" to create a new lock file, and commit it, so the CI could pass.

apologies @davidmeirlevy , i think it should pass now!

@JayGaba JayGaba requested a review from davidmeirlevy October 12, 2024 09:58
@davidmeirlevy davidmeirlevy merged commit a07b521 into configu:main Oct 13, 2024
2 of 3 checks passed
@davidmeirlevy
Copy link
Contributor

@JayGaba merged! thanks for your contribution 👏

@JayGaba
Copy link
Contributor Author
JayGaba commented Oct 13, 2024

@JayGaba merged! thanks for your contribution 👏

Thank you for making my first contribution so smooth! 🚀

alfasin added a commit to alfasin/configu that referenced this pull request Oct 18, 2024
* upstream/main: (27 commits)
  Extended Datetime Cfgu Types (configu#567)
  Implemented datasize Cfgu Type (configu#564)
  feat: Implement SplitConfigStore (configu#554)
  Complete Configu CLI - return run and test commands (configu#545)
  Migrate LocalForageConfigStore to @configu/integrations (configu#563)
  Support glob patterns in .configu schema definitions (configu#548)
  Migrated MSSQLConfigStore to @configu/integrations configu#520 (configu#546)
  Fix "Join Chat 💬" Link in README to Redirect to Discord  (configu#559)
  Gcp secret manager migrate to new module (configu#529)
  feat: Contributors Section to Readme with Dynamic Images (configu#558)
  bug: Incorrect link in readme for Explore Docs (configu#560)
  fix lock file (configu#553)
  add  etcd to @configu/integrations (configu#551)
  migrate KeyvConfigStore to @configu/integrations" (configu#552)
  Migrate KubernetesSecretConfigStore to @configu/integrations (configu#534)
  Migrate MariaDBConfigStore to @configu/integrations (configu#533)
  Add AWSSecretsManagerConfigStore to @configu/integrations (configu#543)
  initial load of integrations that are included inside the cli and proxy (configu#550)
  Add CloudBeesConfigStore to @configu/integrations (configu#542)
  Fixed using the simple way suggested (configu#547)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that every integration build creates one-file only
3 participants
0