8000 Extended Datetime Cfgu Types by JayGaba · Pull Request #567 · configu/configu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extended Datetime Cfgu Types #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2024
Merged

Extended Datetime Cfgu Types #567

merged 3 commits into from
Oct 15, 2024

Conversation

JayGaba
Copy link
Contributor
@JayGaba JayGaba commented Oct 14, 2024 •
edited
Loading

Closes #373

  1. Duration:
  • Added a regex pattern: ^\d+[smhdwMy]$
    • Description: Validates durations like 1h, 2d, 3w.
  1. DateFormat:
  • Added a regex pattern: ^(yyyy|yy|MM|M|dd|d|HH|H|mm|m|ss|s)([.-/\s]?(yyyy|yy|MM|M|dd|d|HH|H|mm|m|ss|s))*$
    • Description: Ensures date formats like yyyy-MM-dd or dd/MM/yyyy HH:mm:ss are valid

@JayGaba JayGaba requested a review from a team as a code owner October 14, 2024 20:54
RichardAkman
RichardAkman requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor
@RichardAkman RichardAkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your PR to account for the conflicts with your other PR that we merged 🙏🏻

Also please remove the type validation from this file, validation of types is the job of EvalCommand

@JayGaba
Merge branch 'main' into datetime
2132834
@JayGaba
Update .cfgu.json
242a800 
Removed validation in the .cfgu.json file
@JayGaba
Copy link
Contributor Author
JayGaba commented Oct 15, 2024

@RichardAkman my bad, can you please review the changes and let me know if this is fine now, thank you!

RichardAkman
RichardAkman approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor
@RichardAkman RichardAkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contributions ⭐ ⭐

@RichardAkman RichardAkman merged commit d39463b into configu:main Oct 15, 2024
1 of 3 checks passed
@JayGaba JayGaba deleted the datetime branch October 15, 2024 13:53
@JayGaba
Copy link
Contributor Author
JayGaba commented Oct 15, 2024

@RichardAkman could you please add hacktoberfest-accepted label, much appreciated!

alfasin added a commit to alfasin/configu that referenced this pull request Oct 18, 2024
@alfasin
Merge remote-tracking branch 'upstream/main'
bf8215c 
* upstream/main: (27 commits)
  Extended Datetime Cfgu Types (configu#567)
  Implemented datasize Cfgu Type (configu#564)
  feat: Implement SplitConfigStore (configu#554)
  Complete Configu CLI - return run and test commands (configu#545)
  Migrate LocalForageConfigStore to @configu/integrations (configu#563)
  Support glob patterns in .configu schema definitions (configu#548)
  Migrated MSSQLConfigStore to @configu/integrations configu#520 (configu#546)
  Fix "Join Chat 💬" Link in README to Redirect to Discord  (configu#559)
  Gcp secret manager migrate to new module (configu#529)
  feat: Contributors Section to Readme with Dynamic Images (configu#558)
  bug: Incorrect link in readme for Explore Docs (configu#560)
  fix lock file (configu#553)
  add  etcd to @configu/integrations (configu#551)
  migrate KeyvConfigStore to @configu/integrations" (configu#552)
  Migrate KubernetesSecretConfigStore to @configu/integrations (configu#534)
  Migrate MariaDBConfigStore to @configu/integrations (configu#533)
  Add AWSSecretsManagerConfigStore to @configu/integrations (configu#543)
  initial load of integrations that are included inside the cli and proxy (configu#550)
  Add CloudBeesConfigStore to @configu/integrations (configu#542)
  Fixed using the simple way suggested (configu#547)
  ...
@pelegpor
Copy link
Contributor

Hi @JayGaba ,

Here are the details for claiming your Hacktoberfest prizes! 🎉 Check out #465 (comment) for more information or simply fill out the form here: Claim Your Swag.

Remember, you only need to fill out the form once for all your PRs. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardAkman RichardAkman RichardAkman approved these changes

Assignees

@JayGaba JayGaba

Labels
community hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Date Time Cfgu Types
3 participants
@JayGaba @pelegpor @RichardAkman
0