8000 Stop decoding things twice by fgsch · Pull Request #1845 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stop decoding things twice #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2021
Merged

Stop decoding things twice #1845

merged 2 commits into from
Feb 1, 2021

Conversation

fgsch
Copy link
Contributor
@fgsch fgsch commented Jul 9, 2020

Fixes #1616.

@fgsch fgsch changed the title Fgsch/revert pr 578 Stop decoding things twice Jul 9, 2020
@fgsch fgsch mentioned this pull request Aug 3, 2020
Closed
@dune73 dune73 mentioned this pull request Aug 3, 2020
Closed
@franbuehler franbuehler self-requested a review August 3, 2020 19:00
@franbuehler franbuehler self-assigned this Aug 3, 2020
franbuehler
franbuehler approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor
@franbuehler franbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and can be merged.

@franbuehler franbuehler mentioned this pull request Sep 7, 2020
Closed
@franbuehler
Copy link
Contributor

Monthly chat meeting September: #1869 (comment).
@fgsch adds more information. Then this PR can be merged.

@dune73 dune73 mentioned this pull request Oct 5, 2020
Closed
@lifeforms
Copy link
Member

TODO from meeting:

  • add more information
  • rebase for conflicts in rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf

Moved to next meeting!

@airween airween mentioned this pull request Oct 22, 2020
Closed
@dune73 dune73 mentioned this pull request Nov 2, 2020
Closed
@franbuehler franbuehler mentioned this pull request Dec 5, 2020
Closed
@dune73 dune73 mentioned this pull request Dec 11, 2020
Closed
@franbuehler franbuehler assigned fgsch and unassigned franbuehler Dec 12, 2020
fgsch added 2 commits December 23, 2020 15:28
@fgsch
Revert coreruleset#578
2094385 
Stop decoding things twice. See coreruleset#590 for details.
@fgsch
Adjust test
5ba8c87
@fgsch fgsch force-pushed the fgsch/revert-pr-578 branch from a7e4277 to 5ba8c87 Compare December 23, 2020 15:29
@dune73
Copy link
Member
dune73 commented Jan 4, 2021

OK. This has been open long enough. Merging now. Thank you for making this change @fgsch.

@fgsch
Copy link
Contributor Author
fgsch commented Jan 4, 2021

Sorry, I am planning to add a longer explanation this week.
If you don't mind waiting another week it'd be great.

@dune73
Copy link
Member
dune73 commented Jan 4, 2021

OK. Let's keep it pending then. A description is indeed welcome, (but I did not think you would submit one :) ).

@dune73 dune73 mentioned this pull request Jan 27, 2021
Closed
@dune73 dune73 merged commit aa8bd48 into coreruleset:v3.4/dev Feb 1, 2021
@dune73
Copy link
Member
dune73 commented Feb 1, 2021

Nevermind. I added a bit of description and merged at last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franbuehler franbuehler franbuehler approved these changes

Assignees

@fgsch fgsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert #578
4 participants
@fgsch @franbuehler @lifeforms @dune73
0