8000 feat(913110): Remove rule (check for security scanner http headers) by dune73 · Pull Request #3241 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(913110): Remove rule (check for security scanner http headers) #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

dune73
Copy link
Member
@dune73 dune73 commented Jun 19, 2023

As discussed in June meeting. This list of HTTP header security scanners are supposed to use. It would be too simple if they would actually use these headers.

Unfortunately, this also removes the x-scanner header which is very useful for CRS fingerprinting. But anyways, it's a useless rule that never triggers and it's time to kick it.

Replaces #3234

franbuehler
franbuehler previously approved these changes Jun 19, 2023
Copy link
Contributor
@franbuehler franbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dune73
Copy link
Member Author
dune73 commented Jun 21, 2023

Removed the 2 conflicts after merge of other PR. Should be ready now. Fingers crossed.

@franbuehler
Copy link
Contributor

@dune73 : Another rebase and then this PR can be merged too.

@dune73
Copy link
Member Author
dune73 commented Jun 23, 2023

Thank you. Ready now.

Copy link
Contributor
@franbuehler franbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0