feat(913110): Remove rule (check for security scanner http headers) #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franbuehler
requested changes
Jun 18, 2023
|
Ah, sucks, I thought I had done that. Done now. |
|
Messed up this PR. Started over with #3241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in June meeting. This list of HTTP header security scanners are supposed to use. It would be too simple if they would actually use these headers.
Unfortunately, this also removes the x-scanner header which is very useful for CRS fingerprinting. But anyways, it's a useless rule that never triggers and it's time to kick it.