8000 fix: range expressions must not start with `\v` by theseion · Pull Request #3615 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: range expressions must not start with \v #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix: range expressions must not start with \v #3615

merged 2 commits into from
Mar 18, 2024

Conversation

theseion
Copy link
Contributor

Fixes #3610

@theseion theseion requested a review from airween March 17, 2024 20:11
@theseion
Copy link
Contributor Author

The lint failure is expected. We first need to merge coreruleset/crs-toolchain#137.

@theseion
Copy link
Contributor Author

@superlgn, @airween Could you test the fixed expressions in this PR? \v has now been replaced with \0xb in character classes.

@airween
Copy link
Contributor
airween commented Mar 17, 2024

@superlgn, @airween Could you test the fixed expressions in this PR? \v has now been replaced with \0xb in character classes.

I pulled your repo and tried it with my Apache2, everything looks fine. I can take a look in detail tomorrow (test few regexes with my tool).

@airween
Copy link
Contributor
airween commented Mar 18, 2024
8000

I run a test with my tool against all regexes, and looks everything is fine.

Please fix the lint error, and I can merge it.

@fzipi fzipi mentioned this pull request Mar 18, 2024
Closed
@theseion
Copy link
Contributor Author

Thanks @airween ❤️!

@dune73
Copy link
Member
dune73 commented Mar 18, 2024

Don't forget to add a remark in CONTRIBUTING.md or somewhere.

@dune73 dune73 added this pull request to the merge queue Mar 18, 2024
Merged via the queue into coreruleset:main with commit 6020c73 Mar 18, 2024
@theseion theseion deleted the fix-invalid-ranges branch March 18, 2024 19:23
@theseion
Copy link
Contributor Author

Don't forget to add a remark in CONTRIBUTING.md or somewhere.

About what? We simply modified the automation, nothing to be done by devs manually.

@dune73
Copy link
Member
dune73 commented Mar 18, 2024

Ah, sorry. I thought you had changed the source regexes. But true, the change would include the ra files then. Did not connect the dots.

@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Merged
@dune73 dune73 mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dune73 dune73 dune73 approved these changes

@airween airween Awaiting requested review from airween

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule syntax error
3 participants
@theseion @airween @dune73
0