fix: do not use \v in character classes
#137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`\v` expands to multiple code points and is, therefore, illegal in PCRE2 when it starts a range. In PCRE, the range token (`-`) following any such escape code would simply be treated as a literal (depending on compile time configuration).
This was referenced Mar 17, 2024
|
Note that this commit branches of v2.0.0 and will need to be released as v2.1.0. |
|
@theseion is this still a draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\vexpands to multiple code points and is, therefore, illegal in PCRE2 when it starts a range. In PCRE, the range token (-) following any such escape code would simply be treated as a literal (depending on compile time configuration).