8000 Restore container logs from checkpoint by rst0git · Pull Request #8290 · cri-o/cri-o · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restore container logs from checkpoint #8290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

Restore container logs from checkpoint #8290

merged 1 commit into from
Jul 5, 2024

Conversation

rst0git
Copy link
Contributor
@rst0git rst0git commented Jun 17, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

A container checkpoint includes a copy of the logs file. However, this file is currently not used during restore. As a result, the output of kubectl logs for a restored container is empty. This pull request extends the current functionality to enable restoring of container logs. This is particularly useful with applications such as Jupyter Notebooks that output an authentication token and access instructions in the container logs.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Enabled restoring container logs from a checkpoint.

@rst0git rst0git requested a review from mrunalp as a code owner June 17, 2024 13:37
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Jun 17, 2024
@openshift-ci openshift-ci bot requested review from klihub and kwilczynski June 17, 2024 13:38
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Jun 17, 2024

Hi @rst0git. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link
codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 49.49%. Comparing base (6524644) to head (eccab8a).
Report is 70 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8290      +/-   ##
==========================================
- Coverage   49.53%   49.49%   -0.05%     
==========================================
  Files         153      153              
  Lines       16960    16975      +15     
==========================================
  Hits         8401     8401              
- Misses       7511     7524      +13     
- Partials     1048     1050       +2

@rst0git
Restore container logs from checkpoint
eccab8a 
A container checkpoint includes a copy of the logs file. However, this
file is currently not used during restore. As a result, the output of
`kubectl logs` for a restored container is empty. This patch extends
the current functionality to enable restoring of container logs.

Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
@saschagrunert
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@saschagrunert
Copy link
Member

Thanks!

@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rst0git, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@saschagrunert
Copy link
Member

/retest

2 similar comments
@saschagrunert
Copy link
Member

/retest

@saschagrunert
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 45bd35a into cri-o:main Jul 5, 2024
69 of 71 checks passed
@rst0git rst0git deleted the restore-logs branch July 6, 2024 06:58
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
@rst0git rst0git mentioned this pull request Dec 3, 2024
Closed
@adrianreber adrianreber mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rst0git @saschagrunert
0