Extend checkpoint/restore test for container logs #9202
Conversation
This extends the checkpoint/restore test to ensure that the container log file (crictl logs) is restored correctly. Signed-off-by: Adrian Reber <areber@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrianreber The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9202 +/- ##
==========================================
- Coverage 47.34% 47.34% -0.01%
==========================================
Files 162 162
Lines 23978 23978
==========================================
- Hits 11353 11352 -1
- Misses 11510 11511 +1
Partials 1115 1115 🚀 New features to boost your workflow:
|
|
Lot's of CI errors. The ones I looked seem to be unrelated to my change. |
|
/skip |
|
/retest |
|
@adrianreber: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -49,6 +57,15 @@ function teardown() { | |||
| crictl start "$ctr_id" | |||
| restored=$(crictl inspect --output go-template --template "{{(index .info.restored)}}" "$ctr_id") | |||
| [[ "$restored" == "true" ]] | |||
| sleep 1 | < 8000 /tr>|||
There was a problem hiding this comment.
if the container is successfully restored, why do we need the sleep?
There was a problem hiding this comment.
The sleep is needed for the log file test. The container prints something every 0.5 seconds and to make sure there are more lines in the log file then before I am waiting for 1 second.
There was a problem hiding this comment.
totally, that makes sense. can you add a comment saying the point?
What type of PR is this?
/kind ci
What this PR does / why we need it:
Which issue(s) this PR fixes:
This extends the checkpoint/restore test to ensure that the container log file (crictl logs) is restored correctly.
Special notes for your reviewer:
Trying to reproduce https://issues.redhat.com/browse/OCPBUGS-55963
Does 8000 this PR introduce a user-facing change?
No