8000 Extend checkpoint/restore test for container logs by adrianreber · Pull Request #9202 · cri-o/cri-o · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extend checkpoint/restore test for container logs #9202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extend checkpoint/restore test for container logs #9202

wants to merge 1 commit into from
+21 −1

Conversation

adrianreber
Copy link
Member

What type of PR is this?

/kind ci

What t 8000 his PR does / why we need it:

Which issue(s) this PR fixes:

This extends the checkpoint/restore test to ensure that the container log file (crictl logs) is restored correctly.

Special notes for your reviewer:

Trying to reproduce https://issues.redhat.com/browse/OCPBUGS-55963

Does this PR introduce a user-facing change?

No

None

@adrianreber adrianreber requested a review from mrunalp as a code owner May 15, 2025 08:34
@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 15, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and littlejawa May 15, 2025 08:34
@openshift-ci openshift-ci bot added kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 15, 2025
@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adrianreber
Once this PR has been reviewed and has the lgtm label, please assign sohankunkerkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 15, 2025
@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.30%. Comparing base (5dd0877) to head (4996d10).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9202      +/-   ##
==========================================
- Coverage   47.34%   47.30%   -0.05%     
==========================================
  Files         162      162              
  Lines       23978    24034      +56     
==========================================
+ Hits        11353    11369      +16     
- Misses      11510    11547      +37     
- Partials     1115     1118       +3
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adrianreber
Copy link
Member Author

Lot's of CI errors. The ones I looked seem to be unrelated to my change.

@adrianreber
Copy link
Member Author

@rst0git mentioned that the functionality was introduced with #8290 and this is now providing tests for #8290.

@bitoku
Copy link
Contributor
bitoku commented May 16, 2025

/skip
/retest

@adrianreber
Copy link
Member Author

/retest

@adrianreber
Extend checkpoint/restore test for container logs
4996d10 
This extends the checkpoint/restore test to ensure that the container
log file (crictl logs) is restored correctly.

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber force-pushed the 2025-05-15-test-log branch from 4840945 to 4996d10 Compare May 19, 2025 06:16
@adrianreber
Copy link
Member Author

/retest

1 similar comment
@adrianreber
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented May 19, 2025

@adrianreber: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-evented-pleg 4996d10 link false /test ci-e2e-evented-pleg

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianreber @saschagrunert @bitoku @haircommander
0