Add support for Map writing to Arrow vtab #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27fc6c8 to
ccaaac0
Compare
ccaaac0 to
0c75302
Compare
|
Thanks a lot for the PR! LGTM |
sgrebnov
added a commit
to spiceai/duckdb-rs
that referenced
this pull request
Feb 25, 2025
lukekim
pushed a commit
to spiceai/duckdb-rs
that referenced
this pull request
Feb 25, 2025
peasee
pushed a commit
to spiceai/duckdb-rs
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds support for writing Map Arrow data type to Arrow vtab.
MapArrayis physically implemented as aListArrayof structs with key and value fields, and support for this can be added usinglist_vectorandstruct_array_to_vector.While working on large Map arrays, I discovered that
StructVector.childmust adjust its vector capacity similarly toListVector.child; otherwise it can reach array capacity ("assertion failed: array.len() <= out.capacity()"). Improved.Note: the lint error is unrelated to this change and due to recently releasedrust version 1.85 / 2025-02-17that automatically applied to the CI (requires improvement incrates/duckdb/src/r2d2.rs:118:31)