8000 Fix Rust 1.85 clippy error by sgrebnov · Pull Request #443 · duckdb/duckdb-rs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Rust 1.85 clippy error #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix Rust 1.85 clippy error #443

merged 1 commit into from
Feb 24, 2025

Conversation

sgrebnov
Copy link
Contributor
@sgrebnov sgrebnov commented Feb 24, 2025 •
edited
Loading

Fixes the following error when running clippy under Rust 1.85 (since 2025-02-17)

cargo clippy --all-targets --workspace --all-features -- -D warnings -A clippy::redundant-closure

error: useless conversion to the same type: `error::Error`
   --> crates/duckdb/src/r2d2.rs:118:31
    |
118 |           conn.execute_batch("").map_err(Into::into)
    |  _______________________________-^^^^^^^^^^^^^^^^^^^
119 | |     }
    | |____- help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
note: the lint level is defined here
   --> crates/duckdb/src/r2d2.rs:1:9
    |
1   | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(clippy::useless_conversion)]` implied by `#[deny(warnings)]`

error: could not compile `duckdb` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `duckdb` (lib test) due to 1 previous error

@sgrebnov sgrebnov mentioned this pull request Feb 24, 2025
Merged
@Maxxen Maxxen merged commit 2a2a562 into duckdb:main Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrebnov @Maxxen
0