Do not pass both stdlib flags. #455
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use sccache in our CI and we encountered errors where the C++ stdlib includes were not found.
Error sample
Digging deeper, it turns out that both
libc++
andlibstdc++
were being passed to the compiler:"-std=c++11" "-stdlib=libc++" "-stdlib=libstdc++"
.According to
cc
s docs, just setting.cpp(true)
automatically passes the expected-stdlib
flags to the compiler.This PR removes the two, seemingly redundant, flags. With this, we are able to use
sccache
again.