Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP #16394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
approved these changes
Feb 25, 2025
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duckdb/duckdb-fuzzer#3990
Fix (I think) Is to not use the DivModPositive Function as it assumes the LHS is positive. However, it seems like when NULL is cast to
Timestampa negative timestamp/hugeint_t value is used.Another fix may be a different timestamp value when casting NULL.
Commit causing the error was 1e404813c9ec1ebe47e4d1b4dccfd86ad978ba7d.
CC @hawkfish