8000 MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation by carlopi · Pull Request #16400 · duckdb/duckdb · GitHub

More Web Proxy on the site http://driver.im/

MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation #16400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mytherin merged 1 commit into duckdb:main from carlopi:fixup_python_130dev_versioning

Feb 25, 2025

Contributor

carlopi commented

Note that duplicating everything 3 times in Python and 1 in CMake is not exactly the best pattern

Follow up of #16366 to handle also Python builds


          MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation

61f5573

Note that duplicating everything 3 times in Python and 1 in CMake is not exactly the best pattern

Follow up of duckdb#16366 to handle also Python builds

carlopi requested a review from Tishj

February 25, 2025 13:00

Mytherin merged commit d608a31 into duckdb:main

49 of 50 checks passed

Collaborator

Mytherin commented

Thanks!

Contributor Author

carlopi commented

I don't understand Python properly, this is the wrong approach, thanks @hmeriann for noticing.

Mytherin reviewed

View reviewed changes

tools/pythonpkg/setup.py



		def git_dev_version():
		# if 'SETUPTOOLS_SCM_PRETEND_VERSION' in os.environ:

Collaborator

Mytherin

This is probably the problem

carlopi added a commit to carlopi/duckdb that referenced this pull request


          Fixup duckdb#16400 by correctly using env variables

f827028

carlopi mentioned this pull request

Fixup #16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION #16435

Merged

Mytherin added a commit that referenced this pull request


          Fixup #16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION (…

b95a2a9

…#16435)

Pointed out by @Mytherin at
#16400 (comment).

Waiting for CI to build those so that I can double check the wheels.

Antonov548 added a commit to Antonov548/duckdb-r that referenced this pull request


          vendor: Update vendored sources to duckdb/duckdb@d608a31

142aa66

MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request


          vendor: Update vendored sources to duckdb/duckdb@5cdaf56

d6f59f6

Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394)
MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request


          vendor: Update vendored sources to duckdb/duckdb@057f975

6f15569

Issue duckdb/duckdb#16250: Window Range Performance (duckdb/duckdb#16438)
Fixup duckdb/duckdb#16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION (duckdb/duckdb#16435)
Python Client: Faster Python Object Conversion (duckdb/duckdb#16431)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request


          vendor: Update vendored sources to duckdb/duckdb@5cdaf56

Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394)
MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request


          vendor: Update vendored sources to duckdb/duckdb@057f975

a8de3a4

Issue duckdb/duckdb#16250: Window Range Performance (duckdb/duckdb#16438)
Fixup duckdb/duckdb#16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION (duckdb/duckdb#16435)
Python Client: Faster Python Object Conversion (duckdb/duckdb#16431)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request


          vendor: Update vendored sources to duckdb/duckdb@5cdaf56

8b33bd1

Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394)
MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request


          vendor: Update vendored sources to duckdb/duckdb@057f975

58ca321

Issue duckdb/duckdb#16250: Window Range Performance (duckdb/duckdb#16438) Fixup duckdb/duckdb#16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION (duckdb/duckdb#16435) Python Client: Faster Python Object Conversion (duckdb/duckdb#16431)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025 vendor: Update vendored sources to duckdb/duckdb@5cdaf56 1e07355 Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400) krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025 vendor: Update vendored sources to duckdb/duckdb@057f975 474cabb Issue duckdb/duckdb#16250: Window Range Performance (duckdb/duckdb#16438) Fixup duckdb/duckdb#16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION (duckdb/duckdb#16435) Python Client: Faster Python Object Conversion (duckdb/duckdb#16431) krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025 vendor: Update vendored sources to duckdb/duckdb@5cdaf56 37987e8 Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400) krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025 vendor: Update vendored sources to duckdb/duckdb@057f975 25c6530 Issue duckdb/duckdb#16250: Window Range Performance (duckdb/duckdb#16438) Fixup duckdb/duckdb#16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION (duckdb/duckdb#16435) Python Client: Faster Python Object Conversion (duckdb/duckdb#16431) krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025 vendor: Update vendored sources to duckdb/duckdb@5cdaf56 cff5cbe Fuzzer Fix: Fix Avg for NULL cast to TIMESTAMP (duckdb/duckdb#16394) MAIN_BRANCH_VERSIONING: Adopt also for Python build and amalgamation (duckdb/duckdb#16400) krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025 vendor: Update vendored sources to duckdb/duckdb@057f975 512c07a Issue duckdb/duckdb#16250: Window Range Performance (duckdb/duckdb#16438) Fixup duckdb/duckdb#16400 by correctly passing down SETUPTOOLS_SCM_PRETEND_VERSION (duckdb/duckdb#16435) Python Client: Faster Python Object Conversion (duckdb/duckdb#16431)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers Mytherin Mytherin left review comments Tishj Awaiting requested review from Tishj Assignees No one assigned Labels None yet Projects None yet Milestone No milestone Development Successfully merging this pull request may close these issues. Uh oh! There was an error while loading. Please reload this page. 2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer © 2025 GitHub, Inc. Footer navigation Terms Privacy Security Status Docs Contact You can’t perform that action at this time.

0