This repository was archived by the owner on Nov 20, 2024. It is now read-only.
add deprecated_consistency #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Feb 12, 2021
pq
approved these changes
Feb 12, 2021
|
|
||
| Do apply `@Deprecated()` consistently: | ||
|
|
||
| - if a class is deprecated its contructors should also be deprecated. |
There was a problem hiding this comment.
=> if a class is deprecated, its constructors should also be deprecated.
| Do apply `@Deprecated()` consistently: | ||
|
|
||
| - if a class is deprecated its contructors should also be deprecated. | ||
| - if a field is deprecated the contructor parameter pointing to it should also be deprecated. |
There was a problem hiding this comment.
=> if a field is deprecated, the constructor parameter pointing to it should also be deprecated.
|
|
||
| - if a class is deprecated its contructors should also be deprecated. | ||
| - if a field is deprecated the contructor parameter pointing to it should also be deprecated. | ||
| - if a contructor parameter pointing to a field is deprecated the field should also be deprecated. |
There was a problem hiding this comment.
=> if a constructor parameter pointing to a field is deprecated, the field should also be deprecated.
pq
reviewed
Feb 12, 2021
|
|
||
| Do apply `@Deprecated()` consistently: | ||
|
|
||
| - if a class is deprecated, its contructors should also be deprecated. |
| Do apply `@Deprecated()` consistently: | ||
|
|
||
| - if a class is deprecated, its contructors should also be deprecated. | ||
| - if a field is deprecated, the contructor parameter pointing to it should also be deprecated. |
|
|
||
| - if a class is deprecated, its contructors should also be deprecated. | ||
| - if a field is deprecated, the contructor parameter pointing to it should also be deprecated. | ||
| - if a contructor parameter pointing to a field is deprecated, the field should also be deprecated. |
|
@pq sorry for the double fix and thanks for the double check :) |
no worries. Thanks for the follow-through! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint to apply
@Deprecated()consistently:Related to flutter/flutter#75903, flutter/flutter#75813, and https://docs.google.com/document/d/1gR-uEryHrAtkU8-6rTg489JbxtBOnTqG_W3WDCcfU00/edit?usp=sharing&resourcekey=0-6Oy2jitxjIWgBFntFZsWmg