deprecated consistency #75903
deprecated consistency #75903
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -195,6 +195,10 @@ class PluginRegistry extends Registrar { | |||
| /// Creates a [Registrar]. | |||
| /// | |||
| /// The argument is ignored. | |||
| @Deprecated( | |||
| 'Use Registrar instead. ' | |||
| 'This feature was deprecated after v1.24.0-7.0.pre.' | |||
There was a problem hiding this comment.
Hello @a14n,
I think here should be v1.26.0-18.0.pre.
There was a problem hiding this comment.
I used the same deprecation notice as the one on the class. They should be consistent.
There was a problem hiding this comment.
Thanks for your explanation.
There was a problem hiding this comment.
Since this is not being removed soon (like typematcher), we should reset the deprecation clock like we did for those that were missing in #75813.
Typematcher has already been announced on multiple channels over the last few months as being on the way out so folks are aware. :)
| @@ -258,23 +258,6 @@ class GlobalObjectKey<T extends State<StatefulWidget>> extends GlobalKey<T> { | |||
| } | |||
| } | |||
|
|
|||
| /// This class is a work-around for the "is" operator not accepting a variable value as its right operand. | |||
| @@ -195,6 +195,10 @@ class PluginRegistry extends Registrar { | |||
| /// Creates a [Registrar]. | |||
| /// | |||
| /// The argument is ignored. | |||
| @Deprecated( | |||
| 'Use Registrar instead. ' | |||
| 'This feature was deprecated after v1.24.0-7.0.pre.' | |||
There was a problem hiding this comment.
Since this is not being removed soon (like typematcher), we should reset the deprecation clock like we did for those that were missing in #75813.
Typematcher has already been announced on multiple channels over the last few months as being on the way out so folks are aware. :)
|
PTAL |
Follow up on #75813 with an (unpublished) lint to catch more places where deprecations are not consistently applied.
/cc @Piinks