8000 Revert "Remove deprecated TypeMatcher class" by Piinks · Pull Request #75734 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Remove deprecated TypeMatcher class" #75734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

Piinks
Copy link
Contributor
@Piinks Piinks commented Feb 9, 2021

Reverts #73751

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 9, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@renyou renyou self-requested a review February 9, 2021 21:47
Copy link
Contributor
@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Piinks
Copy link
Contributor Author
Piinks commented Feb 9, 2021

Landing to make the tree green again 🤞

@Piinks Piinks merged commit 3d2e65f into master Feb 9, 2021
@Piinks Piinks deleted the revert-73751-typeMatcher branch February 9, 2021 21:56
@Piinks Piinks mentioned this pull request Feb 12, 2021
@Piinks Piinks mentioned this pull request Feb 18, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0