8000 build(npm): automatically run build-icons for correct os by ReenigneArcher · Pull Request #2360 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build(npm): automatically run build-icons for correct os #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

build(npm): automatically run build-icons for correct os #2360

merged 1 commit into from
Apr 21, 2025

Conversation

ReenigneArcher
Copy link
Member
@ReenigneArcher ReenigneArcher commented Feb 15, 2025 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR makes it so npm run build-icons works on all standard OSes.

This PR closes NONE

Notes

A new dev dependency was added to simplify this: https://www.npmjs.com/package/run-script-os

Edit: This is draft as I discovered it is not using the activated python venv. Will update once resolved.

@ReenigneArcher ReenigneArcher marked this pull request as draft February 15, 2025 13:36
@ReenigneArcher ReenigneArcher force-pushed the build/npm/automatically-run-build-icons-for-correct-os branch from 52ebb09 to c94da43 Compare February 15, 2025 13:39
@ReenigneArcher ReenigneArcher marked this pull request as ready for review February 15, 2025 13:39
@ReenigneArcher ReenigneArcher marked this pull request as draft February 15, 2025 13:45
@ReenigneArcher
Copy link
Member Author

I opened a bug report in npm for the venv issue. I think this would technically affect the unix commands as well so it's probably not necessary to wait for this to be resolved.

npm/cli#8111

But, I do have an idea on how to detect if we are running in an activated venv which I will work on shortly.

@ReenigneArcher ReenigneArcher mentioned this pull request Apr 3, 2025
Closed
2 tasks
@ReenigneArcher ReenigneArcher force-pushed the build/npm/automatically-run-build-icons-for-correct-os branch 2 times, most recently from 4e6afe2 to 6bcafbe Compare April 3, 2025 22:34
@ReenigneArcher ReenigneArcher marked this pull request as ready for review April 3, 2025 23:12
@ReenigneArcher
Copy link
Member Author

This is working now, but discovered build failures due to an icon name mismatch (#2407).

@ReenigneArcher ReenigneArcher force-pushed the build/npm/automatically-run-build-icons-for-correct-os branch from 6bcafbe to 93d3393 Compare April 5, 2025 23:37
@ReenigneArcher
Copy link
Member Author

This should be good to merge if anyone can review. Thanks!

@Snailedlt Snailedlt merged commit 4a82187 into devicons:develop Apr 21, 2025
5 checks passed
@Snailedlt
Copy link
Collaborator

Great work, thnaks for letting us know when the PR was done :)

Merged

@ReenigneArcher ReenigneArcher deleted the build/npm/automatically-run-build-icons-for-correct-os branch April 21, 2025 14:29
@canaleal canaleal mentioned this pull request Jun 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@canaleal canaleal canaleal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReenigneArcher @Snailedlt @canaleal
0