8000 build(npm): automatically run build-icons for correct os by ReenigneArcher · Pull Request #2360 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build(npm): automatically run build-icons for correct os #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

build(npm): automatically run build-icons for correct os #2360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@ https://www.python.org/downloads/
> **Note**
> Make sure your Python install includes [pip](https://pypi.org/project/pip/)

<h3>Install Selenium</h3>
<h3>Install Dependencies</h3>

```bash
python3 -m pip install --upgrade pip && pip install selenium==4.1.0 requests==2.25.1
python -m pip install -r ./.github/scripts/requirements.txt
```

<h3 id="building-icons">Build the new icons</h3>
Expand All @@ -281,11 +281,7 @@ python3 -m pip install --upgrade pip && pip install selenium==4.1.0 requests==2.
Usually, this is done on each release, but you can have a sneak peek before a release.</p>

```bash
# Linux/Unix
npm run build-icons

# Windows
python3 ./.github/scripts/icomoon_build_githubless.py ./.github/scripts/build_assets/geckodriver-v0.32.2-win64/geckodriver.exe ./icomoon.json ./devicon.json ./icons ./ --headless
```

<i>The process might take a while, depending on your operating system's speed and the amount of icons.</i>
Expand All @@ -311,7 +307,7 @@ npm run dev # Will run on port 8000
<p>Or this command, which does exactly the same, but the port can be customized.</p>

```bash
python3 -m http.server <port>
python -m http.server <port>
```

<p>You're done now! :tada: Your build of Devicons should be available at <code>https://localhost:8000</code> (or the desired port).</p>
Expand Down
18 changes: 18 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@
"peek-test": "python ./.github/scripts/icomoon_peek.py ./.github/scripts/build_assets/geckodriver-v0.32.2-linux64/geckodriver ./icomoon.json ./devicon.json ./icons ./ --pr_title \"$PR_TITLE\"",
"optimize-svg": "gulp optimizeSvg",
"bump": "gulp bumpVersion",
"build-icons": "python3 ./.github/scripts/icomoon_build_githubless.py ./.github/scripts/build_assets/geckodriver-v0.32.2-linux64/geckodriver ./icomoon.json ./devicon.json ./icons ./ --headless",
"build-icons": "run-script-os",
"build-icons:linux:macOS": "python ./.github/scripts/icomoon_build_githubless.py ./.github/scripts/build_assets/geckodriver-v0.32.2-linux64/geckodriver ./icomoon.json ./devicon.json ./icons ./ --headless",
"build-icons:windows": "python ./.github/scripts/icomoon_build_githubless.py ./.github/scripts/build_assets/geckodriver-v0.32.2-win64/geckodriver.exe ./icomoon.json ./devicon.json ./icons ./ --headless",
"build-icons:default": "echo 'Unsupported OS' && exit 1",
"dev": "concurrently \"npm:open-browser\" \"npm:start-local-server\"",
"start-local-server": "python3 -m http.server 8000",
"start-local-server": "python -m http.server 8000",
"open-browser": "node -e \"import('open').then(pkg => pkg.default('http://localhost:8000/docs'))\""
},
"repository": {
Expand All @@ -36,6 +39,7 @@
"gulp-sass": "^5.0.0",
"gulp-svgmin": "^3.0.0",
"open": "^10.0.3",
"run-script-os": "^1.1.6",
"sass": "^1.26.10",
"yargs": "^17.0.0"
}
Expand Down
Loading
0