8000 official mvnw by denis-yuen · Pull Request #163 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

official mvnw #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2022
Merged

official mvnw #163

merged 3 commits into from
Jul 11, 2022

Conversation

denis-yuen
Copy link
Member

dockstore/dockstore#4959 for details for details

  • Check that you pass the basic style checks and unit tests by running mvn clean install

@denis-yuen denis-yuen self-assigned this Jun 17, 2022
@sonarqubecloud
Copy link
sonarqubecloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link
codecov bot commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #163 (39d5497) into develop (64911f5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #163      +/-   ##
===========================================
+ Coverage    67.79%   67.81%   +0.01%     
===========================================
  Files           47       47              
  Lines         5894     5894              
  Branches       771      771              
===========================================
+ Hits          3996     3997       +1     
  Misses        1589     1589              
+ Partials       309      308       -1
Flag Coverage Δ
confidentialtooltests 52.78% <ø> (ø)
confidentialworkflowtests 26.38% <ø> (ø)
nonconfidentialtests 33.10% <ø> (+0.15%) ⬆️
singularitytests 16.98% <ø> (ø)
unittests 6.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/main/java/io/dockstore/client/cli/Client.java 46.63% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64911f5...39d5497. Read the comment docs.

@denis-yuen denis-yuen marked this pull request as ready for review July 7, 2022 17:13
@denis-yuen denis-yuen requested review from a team, amarjandu, david4096, svonworl and coverbeck and removed request for a team July 7, 2022 17:14
@denis-yuen denis-yuen merged commit 927eb54 into develop Jul 11, 2022
@denis-yuen denis-yuen deleted the feature/official_mvnw branch July 11, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@svonworl svonworl svonworl approved these changes

@amarjandu amarjandu Awaiting requested review from amarjandu amarjandu was automatically assigned from dockstore/dockstore

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @coverbeck @svonworl
0